linux-kernel - Re: [v2 5/6] mm: move allocation of gigantic hstates to the start of mm_core

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202307310053.hx4wsFnM-lkp@intel.com>
Date:   Mon, 31 Jul 2023 00:49:25 +0800
From:   kernel test robot <lkp@...el.com>
To:     Usama Arif <usama.arif@...edance.com>, linux-mm@...ck.org,
        muchun.song@...ux.dev, mike.kravetz@...cle.com, rppt@...nel.org
Cc:     oe-kbuild-all@...ts.linux.dev, linux-kernel@...r.kernel.org,
        fam.zheng@...edance.com, liangma@...ngbit.com,
        simon.evans@...edance.com, punit.agrawal@...edance.com,
        Usama Arif <usama.arif@...edance.com>
Subject: Re: [v2 5/6] mm: move allocation of gigantic hstates to the start of
 mm_core_init

Hi Usama,

kernel test robot noticed the following build errors:

[auto build test ERROR on akpm-mm/mm-everything]

url:    https://github.com/intel-lab-lkp/linux/commits/Usama-Arif/mm-hugetlb-Skip-prep-of-tail-pages-when-HVO-is-enabled/20230730-231750
base:   https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git mm-everything
patch link:    https://lore.kernel.org/r/20230730151606.2871391-6-usama.arif%40bytedance.com
patch subject: [v2 5/6] mm: move allocation of gigantic hstates to the start of mm_core_init
config: csky-randconfig-r034-20230730 (https://download.01.org/0day-ci/archive/20230731/202307310053.hx4wsFnM-lkp@intel.com/config)
compiler: csky-linux-gcc (GCC) 12.3.0
reproduce: (https://download.01.org/0day-ci/archive/20230731/202307310053.hx4wsFnM-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202307310053.hx4wsFnM-lkp@intel.com/

All error/warnings (new ones prefixed by >>):

   In file included from mm/readahead.c:132:
>> mm/internal.h:1143:1: error: expected identifier or '(' before '{' token
    1143 | {
         | ^
>> mm/internal.h:1142:27: warning: 'hugetlb_hstate_alloc_gigantic_pages' declared 'static' but never defined [-Wunused-function]
    1142 | static inline void __init hugetlb_hstate_alloc_gigantic_pages(void);
         |                           ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
--
   In file included from mm/mm_init.c:30:
>> mm/internal.h:1143:1: error: expected identifier or '(' before '{' token
    1143 | {
         | ^
>> mm/internal.h:1142:27: warning: 'hugetlb_hstate_alloc_gigantic_pages' used but never defined
    1142 | static inline void __init hugetlb_hstate_alloc_gigantic_pages(void);
         |                           ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
--
   In file included from lib/vsprintf.c:49:
>> lib/../mm/internal.h:1143:1: error: expected identifier or '(' before '{' token
    1143 | {
         | ^
   lib/vsprintf.c: In function 'va_format':
   lib/vsprintf.c:1681:9: warning: function 'va_format' might be a candidate for 'gnu_printf' format attribute [-Wsuggest-attribute=format]
    1681 |         buf += vsnprintf(buf, end > buf ? end - buf : 0, va_fmt->fmt, va);
         |         ^~~
   lib/../mm/internal.h: At top level:
>> lib/../mm/internal.h:1142:27: warning: 'hugetlb_hstate_alloc_gigantic_pages' declared 'static' but never defined [-Wunused-function]
    1142 | static inline void __init hugetlb_hstate_alloc_gigantic_pages(void);
         |                           ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~


vim +1143 mm/internal.h

  1138	
  1139	#ifdef CONFIG_HUGETLBFS
  1140	void __init hugetlb_hstate_alloc_gigantic_pages(void);
  1141	#else
> 1142	static inline void __init hugetlb_hstate_alloc_gigantic_pages(void);
> 1143	{
  1144	}
  1145	#endif /* CONFIG_HUGETLBFS */
  1146	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki