linux-kernel - Re: [PATCH] hid-mcp2200: added driver for GPIOs of MCP2200

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20230730193712.379694-1-johannes@gnu-linux.rocks>
Date:   Sun, 30 Jul 2023 21:37:12 +0200
From:   Johannes Roith <johannes@...-linux.rocks>
To:     christophe.jaillet@...adoo.fr
Cc:     andi.shyti@...nel.org, benjamin.tissoires@...hat.com,
        jikos@...nel.org, johannes@...-linux.rocks,
        linux-input@...r.kernel.org, linux-kernel@...r.kernel.org,
        ak@...klinger.de
Subject: Re: [PATCH] hid-mcp2200: added driver for GPIOs of MCP2200

Hello Andi, hello Christophe,

thanks for the feedback and the hints. I will add most of your suggestions to
the driver and submit a new patch, this time with a correct Version Label.

I need to use dynamic memory allocation for the data passed to 
hid_hw_output_report, overwise the function doesn't work, 0 bytes will be sent.
The memory has to be allocated dynamically because of the DMA usage in the
background. 

But all the over feedback looks good and will be added to the driver.

Best regards,
Johannes