linux-kernel - Re: [PATCH] gpio: pmic-eic-sprd: remove unnecessary call to platform_set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHp75VeBm=DpfhXOBmgHM-5Y9DBNqwdGdcWRzMxn6PVrZCKbKw@mail.gmail.com>
Date:   Sun, 30 Jul 2023 22:50:01 +0300
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     Andrei Coardos <aboutphysycs@...il.com>
Cc:     linux-kernel@...r.kernel.org, linux-gpio@...r.kernel.org,
        zhang.lyra@...il.com, baolin.wang@...ux.alibaba.com,
        orsonzhai@...il.com, andy@...nel.org, brgl@...ev.pl,
        linus.walleij@...aro.org, Alexandru Ardelean <alex@...uggie.ro>
Subject: Re: [PATCH] gpio: pmic-eic-sprd: remove unnecessary call to platform_set_drvdata()

On Fri, Jul 28, 2023 at 9:09 PM Andrei Coardos <aboutphysycs@...il.com> wrote:
>
> This function call was found to be unnecessary as there is no equivalent
> platform_get_drvdata() call to access the private data of the driver. Also,
> the private data is defined in this driver, so there is no risk of it being
> accessed outside of this driver file.

Reviewed-by: Andy Shevchenko <andy.shevchenko@...il.com>

-- 
With Best Regards,
Andy Shevchenko