linux-kernel - Re: [PATCH 0/3] Fix alignment issue and prepare for rust 1.71

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANiq72k7Kwiq+HDLAv+TrrJC1f9a9ZHxsoKxe9dwr-4uxC7o3Q@mail.gmail.com>
Date:   Sun, 30 Jul 2023 22:43:38 +0200
From:   Miguel Ojeda <miguel.ojeda.sandonis@...il.com>
To:     Boqun Feng <boqun.feng@...il.com>
Cc:     rust-for-linux@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-mm@...ck.org, Miguel Ojeda <ojeda@...nel.org>,
        Alex Gaynor <alex.gaynor@...il.com>,
        Wedson Almeida Filho <wedsonaf@...il.com>,
        Gary Guo <gary@...yguo.net>,
        Björn Roy Baron <bjorn3_gh@...tonmail.com>,
        Benno Lossin <benno.lossin@...ton.me>,
        Martin Rodriguez Reboredo <yakoyoku@...il.com>,
        Alice Ryhl <aliceryhl@...gle.com>,
        Dariusz Sosnowski <dsosnowski@...snowski.pl>,
        Geoffrey Thomas <geofft@...reload.com>,
        Fox Chen <foxhlchen@...il.com>,
        John Baublitz <john.m.baublitz@...il.com>,
        Christoph Lameter <cl@...ux.com>,
        Pekka Enberg <penberg@...nel.org>,
        David Rientjes <rientjes@...gle.com>,
        Joonsoo Kim <iamjoonsoo.kim@....com>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Vlastimil Babka <vbabka@...e.cz>,
        Roman Gushchin <roman.gushchin@...ux.dev>,
        Hyeonggon Yoo <42.hyeyoo@...il.com>,
        Kees Cook <keescook@...omium.org>, stable@...r.kernel.org
Subject: Re: [PATCH 0/3] Fix alignment issue and prepare for rust 1.71

On Sun, Jul 30, 2023 at 3:29 AM Boqun Feng <boqun.feng@...il.com> wrote:
>
> Patch #1: introduces the core helper function that help calculate the
> correct size for krealloc(), and also use the helper function to fix
> `__rust_*` ones, this should be backported to stable kernels hence the
> Cc.
>
> Patch #2: use the helper function in KernelAllocator
>
> Patch #3: Bjorn's patch with correct use of the helper function.

Looks good to me, thanks a lot!

> I have to add a few more SAFETY comments in these `__rust_*` functions,
> which may cause conflict with your 1.71 series.

No worries.

> Since all previous patches get refactored a bit, I dropped all the
> Reviewed-bys, appreciate anyone to take a look, thanks!

Thanks Boqun!

Cheers,
Miguel