linux-kernel - Re: [PATCH] md: fix potential OOB in multipath_remove

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <f21e34ca-72ad-26b5-fac4-fd71180719a2@molgen.mpg.de>
Date:   Sun, 30 Jul 2023 11:46:24 +0200
From:   Paul Menzel <pmenzel@...gen.mpg.de>
To:     Song Liu <song@...nel.org>,
        Zhang Shurong <zhang_shurong@...mail.com>,
        Christoph Hellwig <hch@...radead.org>
Cc:     linux-raid@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] md: fix potential OOB in multipath_remove_disk()

Dear Song, Zhang and Christoph,


Am 29.07.23 um 12:46 schrieb Song Liu:
> On Sat, Jul 15, 2023 at 5:45 PM Zhang Shurong wrote:
>>
>> 在 2023年7月13日星期四 CST 上午12:50:19，Christoph Hellwig 写道：
>>> On Thu, Jul 13, 2023 at 12:46:05AM +0800, Zhang Shurong wrote:
>>>> If rddev->raid_disk is greater than mddev->raid_disks, there will be
>>>> an out-of-bounds in multipath_remove_disk. We have already found
>>>> similar reports as follows:
>>>>
>>>> 1) commit d17f744e883b ("md-raid10: fix KASAN warning")
>>>> 2) commit 1ebc2cec0b7d ("dm raid: fix KASAN warning in raid5_remove_disk")
>>>>
>>>> Fix this bug by checking whether the "number" variable is
>>>> valid.
>>>
>>> I think it might just be time to finally dropped the deprecated md
>>> multipath code instead..
>> Should I write another patch to delete them?
> 
> Yes, please write a patch to delete the multipath code.

How would fixing this bug work with the stable series? Probably a 
removal patch wouldn’t be picked, right? Shouldn’t the fix be accepted 
in master, and then the code be removed?


Kind regards,

Paul