[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20230731103445.497e48d8@gandalf.local.home>
Date: Mon, 31 Jul 2023 10:34:45 -0400
From: Steven Rostedt <rostedt@...dmis.org>
To: "Masami Hiramatsu (Google)" <mhiramat@...nel.org>
Cc: LKML <linux-kernel@...r.kernel.org>,
Linux Trace Kernel <linux-trace-kernel@...r.kernel.org>,
Mark Rutland <mark.rutland@....com>
Subject: Re: [PATCH v2] tracing: Add a debug_trace_printk() function
On Sun, 30 Jul 2023 10:43:21 +0900
Masami Hiramatsu (Google) <mhiramat@...nel.org> wrote:
> Sorry, I missed this patch.
> As far as it depends CONFIG_FTRACE_DEBUG_PRINT, this looks good to me.
>
> Reviewed-by: Masami Hiramatsu (Google) <mhiramat@...nel.org>
Thanks, note I've been holding off on applying it to make sure I really do
need it. I have used it twice since posting. It's great to debug something
in the tracing infrastructure ;-)
>
> BTW, what about adding generic trace_loglvl_printk(loglvl, fmt, ...)?
>
> This is a macro that will be expanded to 'trace_loglvl_<N>_printk(fmt, ...)'
> where N is 0-9. Then we can filter the trace_loglvl_N_printk event to a
> specific instance.
Hmm, interesting idea. I'll have to think about it.
-- Steve
Powered by blists - more mailing lists