linux-kernel - Re: [PATCH 03/12] ASoC: dt-bindings: mediatek,mt8188-mt6359: use common sound card

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20230731143859.GA2928327-robh@kernel.org>
Date:   Mon, 31 Jul 2023 08:38:59 -0600
From:   Rob Herring <robh@...nel.org>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
Cc:     Judy Hsiao <judyhsiao@...omium.org>,
        Sylwester Nawrocki <s.nawrocki@...sung.com>,
        Conor Dooley <conor+dt@...nel.org>,
        Takashi Iwai <tiwai@...e.com>,
        linux-mediatek@...ts.infradead.org,
        Fabio Estevam <festevam@...il.com>,
        alsa-devel@...a-project.org, NXP Linux Team <linux-imx@....com>,
        Rao Mandadapu <srivasam@...eaurora.org>,
        Trevor Wu <trevor.wu@...iatek.com>,
        Jonathan Bakker <xc-racer2@...e.ca>,
        Jerome Brunet <jbrunet@...libre.com>,
        linux-arm-kernel@...ts.infradead.org,
        Matthias Brugger <matthias.bgg@...il.com>,
        Cheng-Yi Chiang <cychiang@...omium.org>,
        Pengutronix Kernel Team <kernel@...gutronix.de>,
        devicetree@...r.kernel.org,
        Rohit kumar <quic_rohkumar@...cinc.com>,
        AngeloGioacchino Del Regno 
        <angelogioacchino.delregno@...labora.com>,
        Shengjiu Wang <shengjiu.wang@....com>,
        Shawn Guo <shawnguo@...nel.org>,
        Jaroslav Kysela <perex@...ex.cz>,
        Mark Brown <broonie@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Liam Girdwood <lgirdwood@...il.com>,
        Sascha Hauer <s.hauer@...gutronix.de>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 03/12] ASoC: dt-bindings: mediatek,mt8188-mt6359: use
 common sound card

On Mon, Jul 31, 2023 at 04:51:46AM -0600, Rob Herring wrote:
> 
> On Mon, 31 Jul 2023 11:42:54 +0200, Krzysztof Kozlowski wrote:
> > The mediatek,mt8188-mt6359 Linux sound machine driver requires the
> > "model" property, so binding was incomplete.  Reference the common sound
> > card properties to fix that which also allows to remove duplicated
> > property definitions.  Leave the relevant parts of "audio-routing"
> > description.
> > 
> > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
> > ---
> >  .../bindings/sound/mediatek,mt8188-mt6359.yaml  | 17 +++++++----------
> >  1 file changed, 7 insertions(+), 10 deletions(-)
> > 
> 
> My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
> on your patch (DT_CHECKER_FLAGS is new in v5.13):
> 
> yamllint warnings/errors:
> 
> dtschema/dtc warnings/errors:
> /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/sound/mediatek,mt8188-mt6359.yaml:
> Error in referenced schema matching $id: http://devicetree.org/schemas/sound/sound-card-common.yaml
> /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/sound/mediatek,mt8188-mt6359.example.dtb: sound: False schema does not allow {'compatible': ['mediatek,mt8188-mt6359-evb'], 'model': ['MT6359-EVB'], 'mediatek,platform': [[4294967295]], 'pinctrl-names': ['default'], 'pinctrl-0': [[4294967295]], 'audio-routing': ['Headphone', 'Headphone L', 'Headphone', 'Headphone R', 'AIN1', 'Headset Mic'], 'dai-link-0': {'link-name': ['ETDM3_OUT_BE'], 'dai-format': ['i2s'], 'mediatek,clk-provider': ['cpu'], 'codec': {'sound-dai': [[4294967295]]}}, '$nodename': ['sound']}
> 	from schema $id: http://devicetree.org/schemas/sound/mediatek,mt8188-mt6359.yaml#
> /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/sound/mediatek,mt8188-mt6359.example.dtb: sound: Unevaluated properties are not allowed ('model' was unexpected)
> 	from schema $id: http://devicetree.org/schemas/sound/mediatek,mt8188-mt6359.yaml#

Looks like patch 2 could not be applied causing this.

Rob