linux-kernel - Re: [PATCH v3 0/4] Add optional properties to MAX17040

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 31 Jul 2023 18:49:37 +0300
From:   Iskren Chernev <me@...ren.info>
To:     Svyatoslav Ryhel <clamor95@...il.com>,
        Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
        Marek Szyprowski <m.szyprowski@...sung.com>,
        Matheus Castello <matheus@...tello.eng.br>,
        Sebastian Reichel <sre@...nel.org>,
        Rob Herring <robh+dt@...nel.org>,
        Conor Dooley <conor+dt@...nel.org>,
        Russell King <linux@...linux.org.uk>,
        Alim Akhtar <alim.akhtar@...sung.com>,
        Arnd Bergmann <arnd@...db.de>,
        Jernej Skrabec <jernej.skrabec@...il.com>,
        Claudiu Beznea <claudiu.beznea@...rochip.com>,
        Stefan Hansson <newbie13xd@...il.com>
Cc:     linux-pm@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-samsung-soc@...r.kernel.org
Subject: Re: [PATCH v3 0/4] Add optional properties to MAX17040



On 7/31/23 10:36, Svyatoslav Ryhel wrote:
> Extend properties supported by max17040 fuel gauge if it is accompanied
> by different devices.
> 
> If max17040 is coupled with a charger, pass charger status since it should
> match and max17040 has no dedicated status detection ability.
> 
> max17040_get_online can be reused for PRESENT property since if it is
> online it must be present.
> 
> Finally, max17040 may be coupled with a dedicated thermal sensor which
> monitors battery temperature so lets add support for iio channel to match
> hw setup. With that said, the driver got dependency on CONFIG_IIO which
> was added to Kconfig. All defconfigs apart s5pv210_defconfig have IIO
> already enabled so only s5pv210_defconfig needed adjustment.

[whole series]
Reviewed-by: Iskren Chernev <me@...ren.info>

> ---
> Changes from v2:
> - documentation: fixed typo i2c0 > i2c
> - added dependency on CONFIG_IIO
> - enabled CONFIG_IIO for s5pv210_defconfig to avoid regressions (all other
>   defconfigs which include max17040 already have IIO enabled)
> 
> Changes from v1:
> - documentation: dropped monitored-battery and power-supplies (inherited
>   from inclusion)
> - dropped passing charger health as battery health
> - dropped patch for simple battery cell support
> - switched iio_read_channel_raw to iio_read_channel_processed_scale
> - switched iio_channel_get to devm_iio_channel_get
> - re-organized implementation of temp channel (implemented in way 
>   *_get_optional functions usually act)
> ---
> 
> Svyatoslav Ryhel (4):
>   dt-bindings: power: supply: maxim,max17040: update properties
>   power: max17040: pass status property from supplier
>   power: max17040: get thermal data from adc if available
>   ARM: configs: s5pv210_defconfig: enable IIO required by MAX17040
> 
>  .../bindings/power/supply/maxim,max17040.yaml | 31 +++++++++++++++++++
>  arch/arm/configs/s5pv210_defconfig            |  1 +
>  drivers/power/supply/Kconfig                  |  2 +-
>  drivers/power/supply/max17040_battery.c       | 27 ++++++++++++++++
>  4 files changed, 60 insertions(+), 1 deletion(-)
>