linux-kernel - Re: [PATCH v7 4/4] drm/mediatek: Add DSI support for mt8188 vdosys0

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 31 Jul 2023 16:08:43 +0000
From:   Jason-JH Lin (林睿祥) 
        <Jason-JH.Lin@...iatek.com>
To:     "angelogioacchino.delregno@...labora.com" 
        <angelogioacchino.delregno@...labora.com>,
        "chunkuang.hu@...nel.org" <chunkuang.hu@...nel.org>
CC:     "linux-mediatek@...ts.infradead.org" 
        <linux-mediatek@...ts.infradead.org>,
        Singo Chang (張興國) 
        <Singo.Chang@...iatek.com>,
        Johnson Wang (王聖鑫) 
        <Johnson.Wang@...iatek.com>,
        Jason-ch Chen (陳建豪) 
        <Jason-ch.Chen@...iatek.com>,
        Shawn Sung (宋孝謙) 
        <Shawn.Sung@...iatek.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Nancy Lin (林欣螢) <Nancy.Lin@...iatek.com>,
        "dri-devel@...ts.freedesktop.org" <dri-devel@...ts.freedesktop.org>,
        Project_Global_Chrome_Upstream_Group 
        <Project_Global_Chrome_Upstream_Group@...iatek.com>,
        Nathan Lu (呂東霖) <Nathan.Lu@...iatek.com>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "matthias.bgg@...il.com" <matthias.bgg@...il.com>
Subject: Re: [PATCH v7 4/4] drm/mediatek: Add DSI support for mt8188 vdosys0

Hi Angelo,

Thanks for the reviews.

On Fri, 2023-07-28 at 10:14 +0200, AngeloGioacchino Del Regno wrote:
> Il 27/07/23 18:41, Jason-JH.Lin ha scritto:
> > Add DSI as main display output for mt8188 vdosys0.
> > 
> 
> I would split this commit in two:
> 
> 1. drm/mediatek: dsi: Support dynamic connector selection
> 2. drm/mediatek: Support DSI on MT8188 VDOSYS0
> 
OK, I'll separate this commit like this.

Regards,
Jason-JH.Lin

> Where the first one sets up the mtk_dsi driver for .encoder_index(),
> and
> where the second one is a one-liner simply adding `{0,
> DDP_COMPONENT_DSI0},`
> to the MT8188 main routes array.
> 
> The reason is that if you split it like that, whoever reads the
> commit history
> will immediately understand how to add dynamic connector selection to
> a MTK DRM
> driver, and how to perform the SoC-specific connection....
> 
> Please!
> 
> Thanks,
> Angelo
>