linux-kernel - Re: [PATCH v1 06/14] futex: Add sys_futex

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <878rawnin9.ffs@tglx>
Date:   Mon, 31 Jul 2023 18:35:38 +0200
From:   Thomas Gleixner <tglx@...utronix.de>
To:     Peter Zijlstra <peterz@...radead.org>, axboe@...nel.dk
Cc:     linux-kernel@...r.kernel.org, peterz@...radead.org,
        mingo@...hat.com, dvhart@...radead.org, dave@...olabs.net,
        andrealmeid@...lia.com, Andrew Morton <akpm@...ux-foundation.org>,
        urezki@...il.com, hch@...radead.org, lstoakes@...il.com,
        Arnd Bergmann <arnd@...db.de>, linux-api@...r.kernel.org,
        linux-mm@...ck.org, linux-arch@...r.kernel.org,
        malteskarupke@....de
Subject: Re: [PATCH v1 06/14] futex: Add sys_futex_wait()

On Fri, Jul 21 2023 at 12:22, Peter Zijlstra wrote:
> +int futex_wait(u32 __user *uaddr, unsigned int flags, u32 val, ktime_t *abs_time, u32 bitset)
> +{
> +	struct hrtimer_sleeper timeout, *to;
> +	struct restart_block *restart;
> +	int ret;
> +
> +	to = futex_setup_timer(abs_time, &timeout, flags,
> +			       current->timer_slack_ns);
> +
> +	ret = __futex_wait(uaddr, flags, val, to, bitset);
> +	if (!to)
> +		return ret;

Can you please put an empty new line and a comment between the __futex_wait()
and the if (!to) check? The original code was less obfuscated.

Other than that: Reviewed-by: Thomas Gleixner <tglx@...utronix.de>