linux-kernel - Re: [PATCH 1/2] lsm: change 'target' parameter to 'const' in security

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZMfpGXM5LlDdrENi@aschofie-mobl2>
Date:   Mon, 31 Jul 2023 10:02:17 -0700
From:   Alison Schofield <alison.schofield@...el.com>
To:     Khadija Kamran <kamrankhadijadj@...il.com>
Cc:     paul@...l-moore.com, stephen.smalley.work@...il.com,
        eparis@...isplace.org, selinux@...r.kernel.org,
        linux-kernel@...r.kernel.org, jmorris@...ei.org, serge@...lyn.com,
        linux-security-module@...r.kernel.org, apparmor@...ts.ubuntu.com,
        john.johansen@...onical.com, ztarkhani@...rosoft.com
Subject: Re: [PATCH 1/2] lsm: change 'target' parameter to 'const' in
 security_capget LSM hook

On Mon, Jul 31, 2023 at 12:07:31PM +0500, Khadija Kamran wrote:
> Three LSMs register the implementations for the "capget" hook: AppArmor,
> SELinux, and the normal capability code. Looking at the function
> implementations we may observe that the first parameter "target" is not
> changing.
> 
> Mark the first argument "target" of LSM hook security_capget(...) as
> "const" since it will not be changing in the LSM hook.


The commit message may be simplified, from this:
[PATCH 1/2] lsm: change 'target' parameter to 'const' in security_capget LSM hook

to something like this:
[PATCH 1/2] lsm: Constify the target parameter in security_capget()

"Constify" is the commonly used language in git logs.
See git log --pretty=oneline --abbrev-commit | grep Constify

Alison

 --snip --

>