linux-kernel - Re: [net-next PATCH V2 2/2] octeontx2-af: TC flower offload support for inner VLAN

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1ff19823-beae-3e39-b3b8-2d8e7c94775f@intel.com>
Date:   Mon, 31 Jul 2023 10:24:32 -0700
From:   Jesse Brandeburg <jesse.brandeburg@...el.com>
To:     Suman Ghosh <sumang@...vell.com>, <sgoutham@...vell.com>,
        <gakula@...vell.com>, <sbhatta@...vell.com>, <hkelam@...vell.com>,
        <davem@...emloft.net>, <edumazet@...gle.com>, <kuba@...nel.org>,
        <pabeni@...hat.com>, <netdev@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>, <lcherian@...vell.com>,
        <jerinj@...vell.com>, <simon.horman@...igine.com>
Subject: Re: [net-next PATCH V2 2/2] octeontx2-af: TC flower offload support
 for inner VLAN

On 7/30/2023 7:31 AM, Suman Ghosh wrote:
> This patch extends current TC flower offload support to allow filters
> involving inner VLAN matching, to be offloaded to HW.
> 
> Signed-off-by: Suman Ghosh <sumang@...vell.com>

Use imperative mood please.

if you happened to change the patch for some other reason I might update
the above text to:

Extend the current TC flower offload support to enable filters matching
inner VLAN, and support offload of those filters to hardware.

Otherwise the code looks fine.

Reviewed-by: Jesse Brandeburg <jesse.brandeburg@...el.com>