linux-kernel - Re: [PATCH v4 1/1] ASoC: Intel: maxim-common: get codec number from ACPI table

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <70ff624f-75d3-d6b1-e709-97d7c75ea3da@linux.intel.com>
Date:   Mon, 31 Jul 2023 13:39:58 +0800
From:   "Liao, Bard" <yung-chuan.liao@...ux.intel.com>
To:     Brent Lu <brent.lu@...el.com>, alsa-devel@...a-project.org
Cc:     Cezary Rojewski <cezary.rojewski@...el.com>,
        Pierre-Louis Bossart <pierre-louis.bossart@...ux.intel.com>,
        Liam Girdwood <liam.r.girdwood@...ux.intel.com>,
        Peter Ujfalusi <peter.ujfalusi@...ux.intel.com>,
        Ranjani Sridharan <ranjani.sridharan@...ux.intel.com>,
        Kai Vehmanen <kai.vehmanen@...ux.intel.com>,
        Mark Brown <broonie@...nel.org>,
        Jaroslav Kysela <perex@...ex.cz>,
        Takashi Iwai <tiwai@...e.com>, linux-kernel@...r.kernel.org,
        Ajye Huang <ajye_huang@...pal.corp-partner.google.com>,
        Yong Zhi <yong.zhi@...el.com>,
        Terry Cheong <htcheong@...omium.org>,
        Uday M Bhat <uday.m.bhat@...el.com>,
        Mac Chiang <mac.chiang@...el.com>,
        "Dharageswari . R" <dharageswari.r@...el.com>,
        Kuninori Morimoto <kuninori.morimoto.gx@...esas.com>,
        ye xingchen <ye.xingchen@....com.cn>,
        Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Subject: Re: [PATCH v4 1/1] ASoC: Intel: maxim-common: get codec number from
 ACPI table


On 7/31/2023 6:34 PM, Brent Lu wrote:
> We implement a helper function to get number of codecs from ACPI
> subsystem instead of using quirk flag in machine driver. Also refactor
> module interface by adding max_98390_dai_link() function.
>
> On the sof_rt5682 machine driver side, we remove the quirk flag
> SOF_MAX98390_TWEETER_SPEAKER_PRESENT and use the new interface of
> max98390 to setup dai link.
>
> Signed-off-by: Brent Lu <brent.lu@...el.com>


Looks good to me.

Reviewed-by: Bard Liao <yung-chuan.liao@...ux.intel.com>