linux-kernel - Re: [PATCH v2 1/7] dt-bindings: soc: qcom: Add qcom-pbs bindings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 31 Jul 2023 11:19:25 -0700
From:   Anjelique Melendez <quic_amelende@...cinc.com>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
        <pavel@....cz>, <lee@...nel.org>, <thierry.reding@...il.com>,
        <robh+dt@...nel.org>, <krzysztof.kozlowski+dt@...aro.org>,
        <conor+dt@...nel.org>, <agross@...nel.org>, <andersson@...nel.org>
CC:     <luca.weiss@...rphone.com>, <konrad.dybcio@...aro.org>,
        <u.kleine-koenig@...gutronix.de>, <quic_subbaram@...cinc.com>,
        <linux-leds@...r.kernel.org>, <devicetree@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>, <linux-arm-msm@...r.kernel.org>,
        <linux-pwm@...r.kernel.org>
Subject: Re: [PATCH v2 1/7] dt-bindings: soc: qcom: Add qcom-pbs bindings



On 7/26/2023 12:53 AM, Krzysztof Kozlowski wrote:
> On 25/07/2023 21:34, Anjelique Melendez wrote:
>> Add binding for the Qualcomm Programmable Boot Sequencer device.
>>
>> Signed-off-by: Anjelique Melendez <quic_amelende@...cinc.com>
>> ---
>>  .../bindings/soc/qcom/qcom-pbs.yaml           | 40 +++++++++++++++++++
>>  1 file changed, 40 insertions(+)
>>  create mode 100644 Documentation/devicetree/bindings/soc/qcom/qcom-pbs.yaml
> 
> 
> Again not tested.
> 
> Also, you missed comments. :(
> 
> This is a friendly reminder during the review process.
> 
> It seems my previous comments were not fully addressed. Maybe my
> feedback got lost between the quotes, maybe you just forgot to apply it.
> Please go back to the previous discussion and either implement all
> requested changes or keep discussing them.
> 
> Thank you.
> 
> 
> Best regards,
> Krzysztof
> 
Hi Krzysztof,

Sorry about the testing, found that my dt_binding_checker was out dated and that
is why it has not been picking up those dt_binding errors :/ 

I went back to take a look at the original comments I missed and just wanted to
list them for a quick double check.

1. Rename binding to be qcom,pbs so that it matches compatible
2. Include Soc specific compatibles i.e. 
   compatible:
     items:
       - enum:
         - qcom,pmi632-pbs
       - const: qcom,pbs
3. Fix the example node

Thanks,
Anjelique