linux-kernel - Re: [PATCH v4 09/34] KVM: selftests: Add a selftest for guest prints and formatted asserts

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230731-4335e61b2b2688a925025a9c@orel>
Date:   Mon, 31 Jul 2023 20:22:54 +0200
From:   Andrew Jones <ajones@...tanamicro.com>
To:     Sean Christopherson <seanjc@...gle.com>
Cc:     Paolo Bonzini <pbonzini@...hat.com>, Marc Zyngier <maz@...nel.org>,
        Oliver Upton <oliver.upton@...ux.dev>,
        Christian Borntraeger <borntraeger@...ux.ibm.com>,
        Janosch Frank <frankja@...ux.ibm.com>,
        Claudio Imbrenda <imbrenda@...ux.ibm.com>, kvm@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org, kvmarm@...ts.linux.dev,
        linux-kernel@...r.kernel.org, Thomas Huth <thuth@...hat.com>,
        Philippe Mathieu-Daudé <philmd@...aro.org>,
        Aaron Lewis <aaronlewis@...gle.com>
Subject: Re: [PATCH v4 09/34] KVM: selftests: Add a selftest for guest prints
 and formatted asserts

On Mon, Jul 31, 2023 at 10:19:47AM -0700, Sean Christopherson wrote:
> On Mon, Jul 31, 2023, Sean Christopherson wrote:
> > On Mon, Jul 31, 2023, Andrew Jones wrote:
> > > diff --git a/tools/testing/selftests/kvm/include/ucall_common.h b/tools/testing/selftests/kvm/include/ucall_common.h
> > > index 4cf69fa8bfba..4adf526dc378 100644
> > > --- a/tools/testing/selftests/kvm/include/ucall_common.h
> > > +++ b/tools/testing/selftests/kvm/include/ucall_common.h
> > > @@ -6,8 +6,19 @@
> > >   */
> > >  #ifndef SELFTEST_KVM_UCALL_COMMON_H
> > >  #define SELFTEST_KVM_UCALL_COMMON_H
> > > +#include <linux/kvm.h>
> > >  #include "test_util.h"
> > >  
> > > +#if defined(__aarch64__)
> > > +#define UCALL_EXIT_REASON      KVM_EXIT_MMIO
> > > +#elif defined(__x86_64__)
> > > +#define UCALL_EXIT_REASON      KVM_EXIT_IO
> > > +#elif defined(__s390x__)
> > > +#define UCALL_EXIT_REASON      KVM_EXIT_S390_SIEIC
> > > +#elif defined(__riscv)
> > > +#define UCALL_EXIT_REASON      KVM_EXIT_RISCV_SBI
> > > +#endif
> > > +
> > >  /* Common ucalls */
> > >  enum {
> > >         UCALL_NONE,
> > > 
> > > and then compiled the test for riscv and it passed. I also ran all other
> > > riscv tests successfully.
> > 
> > Can I have your SoB for the ucall_common.h patch?  I'll write a changelog and fold
> > in a separate prep patch for that change.
> 
> On second thought, I take that back.  I think it makes more sense to add a ucall.h
> for each arch and #define the exit type there.  All then move all of the
> ucall_arch_do_ucall() implementations to ucall.h (except maybe x86 while it has
> the horrific save/restore GPRs hack...).  That way the #define is colocated with
> the code that generates the exit reason.

Yup, feel free to just take the above as inspiration and create a
different patch. If you decide you want an s-o-b for the above, though,
then here's one

Signed-off-by: Andrew Jones <ajones@...tanamicro.com>

Thanks,
drew