linux-kernel - Re: [PATCH v1] scsi: be2iscsi: Add length check when parsing nlattrs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 31 Jul 2023 15:45:04 -0400
From:   "Martin K. Petersen" <martin.petersen@...cle.com>
To:     ketan.mukadam@...adcom.com, jejb@...ux.ibm.com,
        linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org,
        Lin Ma <linma@....edu.cn>
Cc:     "Martin K . Petersen" <martin.petersen@...cle.com>
Subject: Re: [PATCH v1] scsi: be2iscsi: Add length check when parsing nlattrs

On Sun, 23 Jul 2023 15:59:38 +0800, Lin Ma wrote:

> beiscsi_iface_set_param parses nlattr with nla_for_each_attr and assumes
> every attributes can be viewed as struct iscsi_iface_param_info.
> 
> This is not true because there is no any nla_policy to validate the
> attributes passed from the upper function iscsi_set_iface_params.
> 
> This patch adds the nla_len check before accessing the nlattr data and
> error return EINVAL if the length check fails.
> 
> [...]

Applied to 6.6/scsi-queue, thanks!

[1/1] scsi: be2iscsi: Add length check when parsing nlattrs
      https://git.kernel.org/mkp/scsi/c/ee0268f230f6

-- 
Martin K. Petersen	Oracle Linux Engineering