linux-kernel - Re: [PATCH v2 1/2] scsi: iscsi: Add length check for nlattr payload

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <169083266401.2873709.2360198964162460177.b4-ty@oracle.com>
Date:   Mon, 31 Jul 2023 15:45:06 -0400
From:   "Martin K. Petersen" <martin.petersen@...cle.com>
To:     lduncan@...e.com, cleech@...hat.com, michael.christie@...cle.com,
        jejb@...ux.ibm.com, vikas.chaudhary@...gic.com,
        JBottomley@...allels.com, mchan@...adcom.com, benli@...adcom.com,
        ogerlitz@...taire.com, open-iscsi@...glegroups.com,
        linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org,
        Lin Ma <linma@....edu.cn>
Cc:     "Martin K . Petersen" <martin.petersen@...cle.com>
Subject: Re: [PATCH v2 1/2] scsi: iscsi: Add length check for nlattr payload

On Tue, 25 Jul 2023 10:45:29 +0800, Lin Ma wrote:

> The current NETLINK_ISCSI netlink parsing loop checks every nlmsg to
> make sure the length is bigger than the sizeof(struct iscsi_uevent) and
> then calls iscsi_if_recv_msg(...).
> 
>   nlh = nlmsg_hdr(skb);
>   if (nlh->nlmsg_len < sizeof(*nlh) + sizeof(*ev) ||
>     skb->len < nlh->nlmsg_len) {
>     break;
>   }
>   ...
>   err = iscsi_if_recv_msg(skb, nlh, &group);
> 
> [...]

Applied to 6.6/scsi-queue, thanks!

[1/2] scsi: iscsi: Add length check for nlattr payload
      https://git.kernel.org/mkp/scsi/c/971dfcb74a80

-- 
Martin K. Petersen	Oracle Linux Engineering