linux-kernel - Re: [PATCH] nvme: Don't fail to resume if NSIDs change

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230731201047.GA14034@lst.de>
Date:   Mon, 31 Jul 2023 22:10:47 +0200
From:   Christoph Hellwig <hch@....de>
To:     "Limonciello, Mario" <mario.limonciello@....com>
Cc:     August Wikerfors <git@...ustwikerfors.se>,
        Keith Busch <kbusch@...nel.org>, axboe@...com, hch@....de,
        sagi@...mberg.me, linux-nvme@...ts.infradead.org,
        linux-kernel@...r.kernel.org, nilskruse97@...il.com,
        David.Chang@....com
Subject: Re: [PATCH] nvme: Don't fail to resume if NSIDs change

On Mon, Jul 31, 2023 at 03:09:08PM -0500, Limonciello, Mario wrote:
> So is it reasonable to just add a check for
>
> ctrl->oacs & NVME_CTRL_OACS_NS_MNGT_SUPP
>
> In the same error handling path as this patch?

No.  There are tons of NVMe devices that only support creating and
deleting namespace out of band, especially in virtualized and cloud
setups.