linux-kernel - Re: [PATCH 1/4] soc: qcom: aoss: Move length requirements from caller

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e4592feb-3878-b0eb-61e4-fb6dfc358e1a@quicinc.com>
Date:   Mon, 31 Jul 2023 14:29:44 -0700
From:   Chris Lew <quic_clew@...cinc.com>
To:     Bjorn Andersson <quic_bjorande@...cinc.com>,
        Bjorn Andersson <andersson@...nel.org>,
        Konrad Dybcio <konrad.dybcio@...aro.org>
CC:     Alex Elder <elder@...nel.org>,
        "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        Mathieu Poirier <mathieu.poirier@...aro.org>,
        <netdev@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <linux-arm-msm@...r.kernel.org>, <linux-remoteproc@...r.kernel.org>
Subject: Re: [PATCH 1/4] soc: qcom: aoss: Move length requirements from caller



On 7/30/2023 9:10 PM, Bjorn Andersson wrote:
> diff --git a/drivers/soc/qcom/qcom_aoss.c b/drivers/soc/qcom/qcom_aoss.c
>   	/* The message RAM only implements 32-bit accesses */
>   	__iowrite32_copy(qmp->msgram + qmp->offset + sizeof(u32),
> -			 data, len / sizeof(u32));
> -	writel(len, qmp->msgram + qmp->offset);
> +			 buf, sizeof(buf) / sizeof(u32));
> +	writel(sizeof(buf), qmp->msgram + qmp->offset);
>   

Looks like we are telling the firmware the packet size will always be 
QMP_MSG_LEN?

This should be ok but might be a problem when debugging. The AOSS 
firmware only logs size of the message instead of the full string 
because of memory constraints.

We would normally match the firmware and host logs based on size, but 
won't be able to differentiate this way with a fixed size.