linux-kernel - Re: [PATCH next 1/3] selftests:connector: Fix Makefile to include KHDR

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <AC6FD641-54FA-4B60-A0C3-27987C7588CA@oracle.com>
Date:   Mon, 31 Jul 2023 21:55:06 +0000
From:   Anjali Kulkarni <anjali.k.kulkarni@...cle.com>
To:     Shuah Khan <skhan@...uxfoundation.org>
CC:     Shuah Khan <shuah@...nel.org>,
        Liam Howlett <liam.howlett@...cle.com>,
        "naresh.kamboju@...aro.org" <naresh.kamboju@...aro.org>,
        "kuba@...nel.org" <kuba@...nel.org>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "lkft-triage@...ts.linaro.org" <lkft-triage@...ts.linaro.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "llvm@...ts.linux.dev" <llvm@...ts.linux.dev>,
        "linux-kselftest@...r.kernel.org" <linux-kselftest@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH next 1/3] selftests:connector: Fix Makefile to include
 KHDR_INCLUDES



> On Jul 28, 2023, at 10:29 AM, Shuah Khan <skhan@...uxfoundation.org> wrote:
> 
> The test compile fails with following errors. Fix the Makefile
> CFLAGS to include KHDR_INCLUDES to pull in uapi defines.
> 
> gcc -Wall     proc_filter.c  -o ../tools/testing/selftests/connector/proc_filter
> proc_filter.c: In function ‘send_message’:
> proc_filter.c:22:33: error: invalid application of ‘sizeof’ to incomplete type ‘struct proc_input’
>   22 |                          sizeof(struct proc_input))
>      |                                 ^~~~~~
> proc_filter.c:42:19: note: in expansion of macro ‘NL_MESSAGE_SIZE’
>   42 |         char buff[NL_MESSAGE_SIZE];
>      |                   ^~~~~~~~~~~~~~~
> proc_filter.c:22:33: error: invalid application of ‘sizeof’ to incomplete type ‘struct proc_input’
>   22 |                          sizeof(struct proc_input))
>      |                                 ^~~~~~
> proc_filter.c:48:34: note: in expansion of macro ‘NL_MESSAGE_SIZE’
>   48 |                 hdr->nlmsg_len = NL_MESSAGE_SIZE;
>      |                                  ^~~~~~~~~~~~~~~
> `
> 
> Reported-by: Naresh Kamboju <naresh.kamboju@...aro.org>
> Link: https://urldefense.com/v3/__https://lore.kernel.org/all/CA*G9fYt=6ysz636XcQ=-KJp7vJcMZ=NjbQBrn77v7vnTcfP2cA@mail.gmail.com/__;Kw!!ACWV5N9M2RV99hQ!LJI4riV83FdITmzoXmCfxlHKGSeevxg-wn6_ISa7txpETYWPxbtVkAtxSg6IZGi3k5oh2BKMyrbn9464kchHYnuqPEaU$ 
> Signed-off-by: Shuah Khan <skhan@...uxfoundation.org>

Reviewed-by: Anjali Kulkarni <anjali.k.kulkarni@...cle.com>

> ---
> tools/testing/selftests/connector/Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/testing/selftests/connector/Makefile b/tools/testing/selftests/connector/Makefile
> index 21c9f3a973a0..92188b9bac5c 100644
> --- a/tools/testing/selftests/connector/Makefile
> +++ b/tools/testing/selftests/connector/Makefile
> @@ -1,5 +1,5 @@
> # SPDX-License-Identifier: GPL-2.0
> -CFLAGS += -Wall
> +CFLAGS += -Wall $(KHDR_INCLUDES)
> 
> TEST_GEN_PROGS = proc_filter
> 
> -- 
> 2.39.2
>