[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <CAJuCfpELFyY6GAU1aS2T=Z3KxLGnZWRjf32vyRb4dNVF9E7DjA@mail.gmail.com>
Date: Mon, 31 Jul 2023 16:16:39 -0700
From: Suren Baghdasaryan <surenb@...gle.com>
To: Randy Dunlap <rdunlap@...radead.org>
Cc: linux-kernel@...r.kernel.org, kernel test robot <lkp@...el.com>,
Johannes Weiner <hannes@...xchg.org>,
Ingo Molnar <mingo@...hat.com>,
Peter Zijlstra <peterz@...radead.org>,
Juri Lelli <juri.lelli@...hat.com>,
Vincent Guittot <vincent.guittot@...aro.org>
Subject: Re: [PATCH] PSI: select KERNFS as needed
On Mon, Jul 31, 2023 at 4:13 PM Randy Dunlap <rdunlap@...radead.org> wrote:
>
>
>
> On 7/31/23 11:17, Suren Baghdasaryan wrote:
> > On Mon, Jul 31, 2023 at 11:14 AM Suren Baghdasaryan <surenb@...gle.com> wrote:
> >>
> >> On Sun, Jul 30, 2023 at 8:07 PM Randy Dunlap <rdunlap@...radead.org> wrote:
> >>>
> >>> Users of KERNFS should select it to enforce its being built, so
> >>> do this to prevent a build error.
> >>>
> >>> In file included from ../kernel/sched/build_utility.c:97:
> >>> ../kernel/sched/psi.c: In function 'psi_trigger_poll':
> >>> ../kernel/sched/psi.c:1479:17: error: implicit declaration of function 'kernfs_generic_poll' [-Werror=implicit-function-declaration]
> >>> 1479 | kernfs_generic_poll(t->of, wait);
> >>>
> >>> Fixes: aff037078eca ("sched/psi: use kernfs polling functions for PSI trigger polling")
> >>> Signed-off-by: Randy Dunlap <rdunlap@...radead.org>
> >>> Reported-by: kernel test robot <lkp@...el.com>
> >
> > shouldn't this include:
> > Closes: https://lore.kernel.org/oe-kbuild-all/202307310732.r65EQFY0-lkp@intel.com/
> > ?
> >
>
> That's the same URL as the Link: below.
> The difference(s) in Closes: and Link: are not clear to me,
> other than Closes: is newer.
Either way, LGTM. Thanks!
>
> >>> Link: lore.kernel.org/r/202307310732.r65EQFY0-lkp@...el.com
> >>> Cc: Johannes Weiner <hannes@...xchg.org>
> >>> Cc: Suren Baghdasaryan <surenb@...gle.com>
> >>> Cc: Ingo Molnar <mingo@...hat.com>
> >>> Cc: Peter Zijlstra <peterz@...radead.org>
> >>> Cc: Juri Lelli <juri.lelli@...hat.com>
> >>> Cc: Vincent Guittot <vincent.guittot@...aro.org>
> >>
> >> Acked-by: Suren Baghdasaryan <surenb@...gle.com>
> >>
> >> Thanks!
> >>
> >>
> >>> ---
> >>> init/Kconfig | 1 +
> >>> 1 file changed, 1 insertion(+)
> >>>
> >>> diff -- a/init/Kconfig b/init/Kconfig
> >>> --- a/init/Kconfig
> >>> +++ b/init/Kconfig
> >>> @@ -629,6 +629,7 @@ config TASK_IO_ACCOUNTING
> >>>
> >>> config PSI
> >>> bool "Pressure stall information tracking"
> >>> + select KERNFS
> >>> help
> >>> Collect metrics that indicate how overcommitted the CPU, memory,
> >>> and IO capacity are in the system.
>
> --
> ~Randy
Powered by blists - more mailing lists