linux-kernel - RE: [PATCH v1 2/2] doc: dt: bindings: usb: realtek,dwc3: Add Realtek DHC RTD SoC DWC3 USB

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <74e8f0f1c0ec4196b242a1d5b47979d8@realtek.com>
Date:   Mon, 31 Jul 2023 06:25:36 +0000
From:   Stanley Chang[昌育德] 
        <stanley_chang@...ltek.com>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
        Thinh Nguyen <Thinh.Nguyen@...opsys.com>
CC:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Conor Dooley <conor+dt@...nel.org>,
        "linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH v1 2/2] doc: dt: bindings: usb: realtek,dwc3: Add Realtek DHC RTD SoC DWC3 USB

Hi Krzysztof,

> >>> +  realtek,enable-l4icg:
> >>> +    description: Enable the power saving feature l4icg by hardware
> clock.
> >>> +      gating.
> >>
> >> You described the desired Linux feature or behavior, not the actual
> hardware.
> >> The bindings are about the latter, so instead you need to rephrase
> >> the property and its description to match actual hardware
> >> capabilities/features/configuration etc.
> >
> > The l4icg entry is a hardware feature for power saving.
> > The term may not clearly convey the function.
> > So instead of the term "l4icg" I use "hw clock gating".
> >
> >   realtek,enable-hw-clock-gating:
> >     description: Enable the clock gated function which will gating sram
> >       clock when dbus idle.
> 
> And why this should be configurable per board? It looks you like to put OS
> policy into DT, so no.
> 
Ok, I'll remove it from DT.
I put it in DT because hw-clock-gating is not an OS policy. This is a pure hardware function and is not controlled by software.
I want to control enabling or disabling on different SoCs or boards.
But for power saving, it should be enabled by default except for rtd1295 SoC.
So I would handle this special case of rtd1295 in the driver.

Thanks,
Stanley