[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20230731063507epcms2p185efd3a1774bf0482cd7133a509863d6@epcms2p1>
Date: Mon, 31 Jul 2023 15:35:07 +0900
From: Jinyoung Choi <j-young.choi@...sung.com>
To: "hch@....de" <hch@....de>
CC: "martin.petersen@...cle.com" <martin.petersen@...cle.com>,
"axboe@...nel.dk" <axboe@...nel.dk>,
"sagi@...mberg.me" <sagi@...mberg.me>,
"kbusch@...nel.org" <kbusch@...nel.org>,
"chaitanya.kulkarni@....com" <chaitanya.kulkarni@....com>,
"linux-block@...r.kernel.org" <linux-block@...r.kernel.org>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE:(2) [PATCH 2/2] bio-integrity: create multi-page bvecs in
bio_integrity_add_page()
> On Fri, Jul 28, 2023 at 04:57:53PM +0900, Jinyoung Choi wrote:
> > Allow bio_integrity_add_page to create multi-page bvecs, just like
> > the bio payloads. This simplifies adding larger payloads, and fixes
> > support for non-tiny workloads with nvme, which stopped using
> > scatterlist for metadata a while ago
>
> Missing dot at the end of the sentence here. Also the commit log feels
> very short to me for such a substanial change, although even thinking
> hard about it I'm not entirely sure what would be missing, so it's
> probably fine..
>
> Looks good to me:
>
> Reviewed-by: Christoph Hellwig <hch@....de>
Hi, Christoph.
I will add a commit message for the substanial change.
Oh, and I missed some patches that should be included in the patch set.
In the next version, I will add patches that are affected by this patch
and must be changed.
Thank you for your review.
Best Regards,
Jinyoung.
Powered by blists - more mailing lists