linux-kernel - Re: [PATCH] scsi:libsas: Simplify sas_queue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <27bb586c-af75-c2da-1b07-02bfb08e5891@huawei.com>
Date:   Mon, 31 Jul 2023 09:44:39 +0800
From:   Jason Yan <yanaijie@...wei.com>
To:     Wenchao Hao <haowenchao2@...wei.com>,
        John Garry <john.g.garry@...cle.com>,
        "James E . J . Bottomley" <jejb@...ux.ibm.com>,
        "Martin K . Petersen" <martin.petersen@...cle.com>,
        Damien Le Moal <dlemoal@...nel.org>,
        <linux-scsi@...r.kernel.org>, <linux-kernel@...r.kernel.org>
CC:     <louhongxiang@...wei.com>
Subject: Re: [PATCH] scsi:libsas: Simplify sas_queue_reset and remove unused
 code

Hi Wenchao,

On 2023/7/29 18:24, Wenchao Hao wrote:
> sas_queue_reset is always called with param "wait" set to 0, so
> remove it from this function's param list. And remove unused
> function sas_wait_eh.

I did not find any users passing '1' to sas_queue_reset() in the git 
history. It seems it is never used. So It's ok to remove it, I guess.

Just one nit, there should be a blank between "scsi:" and "libsas" in 
the subject:

scsi: libsas: Simplify sas_queue_reset and remove unused code

Otherwise looks good to me:
Reviewed-by: Jason Yan <yanaijie@...wei.com>