linux-kernel - Re: [PATCH V3 5/5] ASoC: codecs: aw88261 chip register file, Kconfig and Makefile

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230731064428.4158-1-wangweidong.a@awinic.com>
Date:   Mon, 31 Jul 2023 14:44:28 +0800
From:   wangweidong.a@...nic.com
To:     krzysztof.kozlowski@...aro.org
Cc:     13916275206@....com, alsa-devel@...a-project.org,
        broonie@...nel.org, ckeepax@...nsource.cirrus.com,
        colin.i.king@...il.com, conor+dt@...nel.org,
        devicetree@...r.kernel.org, doug@...morgal.com, fido_max@...ox.ru,
        herve.codina@...tlin.com, krzysztof.kozlowski+dt@...aro.org,
        lgirdwood@...il.com, linux-kernel@...r.kernel.org,
        liweilei@...nic.com, perex@...ex.cz, povik+lin@...ebit.org,
        rf@...nsource.cirrus.com, robh+dt@...nel.org, ryans.lee@...log.com,
        shumingf@...ltek.com, tiwai@...e.com, trix@...hat.com,
        wangweidong.a@...nic.com, yijiangtao@...nic.com,
        zhangjianming@...nic.com
Subject: Re: [PATCH V3 5/5] ASoC: codecs: aw88261 chip register file, Kconfig and Makefile

Thank you very much for your advice.

> On 29/07/2023 11:12, wangweidong.a@...nic.com wrote:
>> From: Weidong Wang <wangweidong.a@...nic.com>
>> 
>> Mainly includes aw88261 register table, Makefile and Kconfig.
>> 
>> Signed-off-by: Weidong Wang <wangweidong.a@...nic.com>
>> ---
>>  sound/soc/codecs/Kconfig               |  15 +
>>  sound/soc/codecs/Makefile              |   3 +
>>  sound/soc/codecs/aw88261/aw88261_reg.h | 374 +++++++++++++++++++++++++
>>  3 files changed, 392 insertions(+)
>>  create mode 100644 sound/soc/codecs/aw88261/aw88261_reg.h
>> 
>> diff --git a/sound/soc/codecs/Kconfig b/sound/soc/codecs/Kconfig
>> index c2de4ee72183..1e3526812cc8 100644
>> --- a/sound/soc/codecs/Kconfig
>> +++ b/sound/soc/codecs/Kconfig
>> @@ -55,6 +55,7 @@ config SND_SOC_ALL_CODECS
>>  	imply SND_SOC_ALC5632
>>  	imply SND_SOC_AW8738
>>  	imply SND_SOC_AW88395
>> +	imply SND_SOC_AW88261
>>  	imply SND_SOC_BT_SCO
>>  	imply SND_SOC_BD28623
>>  	imply SND_SOC_CHV3_CODEC
>> @@ -640,6 +641,20 @@ config SND_SOC_AW88395
>>  	  digital Smart K audio amplifier with an integrated 10V
>>  	  smart boost convert.
>>  
>> +config SND_SOC_AW88261
>> +	tristate "Soc Audio for awinic aw88261"
>> +	depends on I2C
>> +	select CRC8
>> +	select REGMAP_I2C
>> +	select GPIOLIB
>> +	select SND_SOC_AW88395_LIB
>> +	help
>> +	  This option enables support for aw88261 Smart PA.
>> +	  The awinic AW88261 is an I2S/TDM input, high efficiency
>> +	  digital Smart K audio amplifier. The output voltage of
>> +	  boost converter can be adjusted smartly according to
>> +	  the input amplitude.
>> +
>>  config SND_SOC_BD28623
>>  	tristate "ROHM BD28623 CODEC"
>>  	help
>> diff --git a/sound/soc/codecs/Makefile b/sound/soc/codecs/Makefile
>> index b48a9a323b84..9df43de213f0 100644
>> --- a/sound/soc/codecs/Makefile
>> +++ b/sound/soc/codecs/Makefile
>> @@ -49,6 +49,8 @@ snd-soc-aw8738-objs := aw8738.o
>>  snd-soc-aw88395-lib-objs := aw88395/aw88395_lib.o
>>  snd-soc-aw88395-objs := aw88395/aw88395.o \
>>  			aw88395/aw88395_device.o
>> +snd-soc-aw88261-objs := aw88261/aw88261.o \
>> +			aw88261/aw88261_device.o
>>  snd-soc-bd28623-objs := bd28623.o
>>  snd-soc-bt-sco-objs := bt-sco.o
>>  snd-soc-chv3-codec-objs := chv3-codec.o
>> @@ -431,6 +433,7 @@ obj-$(CONFIG_SND_SOC_ARIZONA)	+= snd-soc-arizona.o
>>  obj-$(CONFIG_SND_SOC_AW8738)	+= snd-soc-aw8738.o
>>  obj-$(CONFIG_SND_SOC_AW88395_LIB) += snd-soc-aw88395-lib.o
>>  obj-$(CONFIG_SND_SOC_AW88395)	+=snd-soc-aw88395.o
>> +obj-$(CONFIG_SND_SOC_AW88261)	+=snd-soc-aw88261.o
>>  obj-$(CONFIG_SND_SOC_BD28623)	+= snd-soc-bd28623.o
>>  obj-$(CONFIG_SND_SOC_BT_SCO)	+= snd-soc-bt-sco.o
>>  obj-$(CONFIG_SND_SOC_CHV3_CODEC) += snd-soc-chv3-codec.o
>> diff --git a/sound/soc/codecs/aw88261/aw88261_reg.h b/sound/soc/codecs/aw88261/aw88261_reg.h
>> new file mode 100644
>> index 000000000000..7ef128a3e6ee
>> --- /dev/null
>> +++ b/sound/soc/codecs/aw88261/aw88261_reg.h
>> @@ -0,0 +1,374 @@
>> +// SPDX-License-Identifier: GPL-2.0-only

> If you add the headers now, it means they are not used in any previous
> patches. Therefore drop the header - it is useless.

I will combine this file with aw88261.c aw88261.h to form a patch #4.
But I have a question as to whether the Makefile and Kconfig files 
need to be separate to make up patch #5?

Best regards,
Weidong Wang