linux-kernel - Re: [net-next PATCH V2 2/2] octeontx2-af: TC flower offload support for inner VLAN

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ZMdc2Aca5AbvPKS1@kernel.org>
Date:   Mon, 31 Jul 2023 09:03:52 +0200
From:   Simon Horman <horms@...nel.org>
To:     Suman Ghosh <sumang@...vell.com>
Cc:     sgoutham@...vell.com, gakula@...vell.com, sbhatta@...vell.com,
        hkelam@...vell.com, davem@...emloft.net, edumazet@...gle.com,
        kuba@...nel.org, pabeni@...hat.com, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, lcherian@...vell.com,
        jerinj@...vell.com, simon.horman@...igine.com
Subject: Re: [net-next PATCH V2 2/2] octeontx2-af: TC flower offload support
 for inner VLAN

On Sun, Jul 30, 2023 at 01:30:09PM +0530, Suman Ghosh wrote:
> This patch extends current TC flower offload support to allow filters
> involving inner VLAN matching, to be offloaded to HW.
> 
> Signed-off-by: Suman Ghosh <sumang@...vell.com>

...

> diff --git a/drivers/net/ethernet/marvell/octeontx2/nic/otx2_tc.c b/drivers/net/ethernet/marvell/octeontx2/nic/otx2_tc.c
> index f311fa6db7ce..29565680f6c4 100644
> --- a/drivers/net/ethernet/marvell/octeontx2/nic/otx2_tc.c
> +++ b/drivers/net/ethernet/marvell/octeontx2/nic/otx2_tc.c
> @@ -447,10 +447,11 @@ static int otx2_tc_process_vlan(struct otx2_nic *nic, struct flow_msg *flow_spec
>  	u16 vlan_tci, vlan_tci_mask;
>  
>  	if (is_inner)
> -		return -EOPNOTSUPP;
> +		flow_rule_match_cvlan(rule, &match);
> +	else
> +		flow_rule_match_vlan(rule, &match);
>  
> -	flow_rule_match_vlan(rule, &match);
> -	if (ntohs(match.key->vlan_tpid) != ETH_P_8021Q) {
> +	if (!eth_type_vlan(ntohs(match.key->vlan_tpid))) {

Hi Suman,

I think this should be:

	if (!eth_type_vlan(match.key->vlan_tpid)) {

Otherwise the patch-set looks good to me.

>  		netdev_err(nic->netdev, "vlan tpid 0x%x not supported\n",
>  			   ntohs(match.key->vlan_tpid));
>  		return -EOPNOTSUPP;

...