linux-kernel - Re: [PATCH -next] RDMA/irdma: Fix one kernel-doc comment

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sun, 30 Jul 2023 19:18:43 -0700
From:   Randy Dunlap <rdunlap@...radead.org>
To:     Yang Li <yang.lee@...ux.alibaba.com>, mustafa.ismail@...el.com,
        shiraz.saleem@...el.com, jgg@...pe.ca, leon@...nel.org,
        linux-rdma@...r.kernel.org, linux-kernel@...r.kernel.org
Cc:     Abaci Robot <abaci@...ux.alibaba.com>
Subject: Re: [PATCH -next] RDMA/irdma: Fix one kernel-doc comment



On 7/30/23 18:59, Yang Li wrote:
> Remove description of @free_hwcqp in irdma_destroy_cqp().
> to silence the warning:
> 
> drivers/infiniband/hw/irdma/hw.c:580: warning: Excess function parameter 'free_hwcqp' description in 'irdma_destroy_cqp'
> 
> Reported-by: Abaci Robot <abaci@...ux.alibaba.com>
> Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=6028
> Signed-off-by: Yang Li <yang.lee@...ux.alibaba.com>

Reviewed-by: Randy Dunlap <rdunlap@...radead.org>

Thanks.

> ---
>  drivers/infiniband/hw/irdma/hw.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/infiniband/hw/irdma/hw.c b/drivers/infiniband/hw/irdma/hw.c
> index eaf196985f49..7cbdd5433dba 100644
> --- a/drivers/infiniband/hw/irdma/hw.c
> +++ b/drivers/infiniband/hw/irdma/hw.c
> @@ -571,7 +571,6 @@ static void irdma_destroy_irq(struct irdma_pci_f *rf,
>  /**
>   * irdma_destroy_cqp  - destroy control qp
>   * @rf: RDMA PCI function
> - * @free_hwcqp: 1 if hw cqp should be freed
>   *
>   * Issue destroy cqp request and
>   * free the resources associated with the cqp

-- 
~Randy