linux-kernel - Re: [PATCH v3 6/8] soc: qcom: socinfo: adjust the position of QDU1010

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b20862ba-bfa5-69b8-08e6-08ce76cf36a5@quicinc.com>
Date:   Mon, 31 Jul 2023 15:22:30 +0800
From:   Tengfei Fan <quic_tengfan@...cinc.com>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
        <andersson@...nel.org>, <konrad.dybcio@...aro.org>,
        <robh+dt@...nel.org>, <krzysztof.kozlowski+dt@...aro.org>,
        <conor+dt@...nel.org>
CC:     <quic_tsoni@...cinc.com>, <quic_shashim@...cinc.com>,
        <quic_kaushalk@...cinc.com>, <quic_tdas@...cinc.com>,
        <quic_tingweiz@...cinc.com>, <quic_aiquny@...cinc.com>,
        <kernel@...cinc.com>, <linux-arm-msm@...r.kernel.org>,
        <devicetree@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v3 6/8] soc: qcom: socinfo: adjust the position of QDU1010



在 7/31/2023 3:00 PM, Krzysztof Kozlowski 写道:
> On 31/07/2023 08:13, Tengfei Fan wrote:
>> Adjust the position of QDU1010, so that QDU1010 have
>> same sequence with QCOM_ID_QDU1010 in bindings file.
>>
>> Change-Id: I86d46eca55e877aaa1fd948db99b41ae138a3129
> 
> Please run scripts/checkpatch.pl and fix reported warnings. Some
> warnings can be ignored, but the code here looks like it needs a fix.
> Feel free to get in touch if the warning is not clear.
> 
will check if still need this patch.
>> ---
>>   drivers/soc/qcom/socinfo.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/soc/qcom/socinfo.c b/drivers/soc/qcom/socinfo.c
>> index 4d49945b3a35..ad7699b401a8 100644
>> --- a/drivers/soc/qcom/socinfo.c
>> +++ b/drivers/soc/qcom/socinfo.c
>> @@ -405,8 +405,8 @@ static const struct soc_id soc_id[] = {
>>   	{ qcom_board_id(SA8775P) },
>>   	{ qcom_board_id(QRU1000) },
>>   	{ qcom_board_id(QDU1000) },
>> -	{ qcom_board_id(QDU1010) },
>>   	{ qcom_board_id(IPQ5019) },
> 
> Same comment as on previous patch.
> 
Will remove this patch, another is handling this: 
https://lore.kernel.org/lkml/20230724083745.1015321-1-quic_kathirav@quicinc.com/T/
>> +	{ qcom_board_id(QDU1010) },
> 
> Best regards,
> Krzysztof
> 

-- 
Thx and BRs,
Tengfei Fan