[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <dc327138-0fc2-0766-0d86-08977b07fb76@linaro.org>
Date: Mon, 31 Jul 2023 10:02:36 +0200
From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To: Tengfei Fan <quic_tengfan@...cinc.com>, andersson@...nel.org,
konrad.dybcio@...aro.org, robh+dt@...nel.org,
krzysztof.kozlowski+dt@...aro.org, conor+dt@...nel.org
Cc: quic_tsoni@...cinc.com, quic_shashim@...cinc.com,
quic_kaushalk@...cinc.com, quic_tdas@...cinc.com,
quic_tingweiz@...cinc.com, quic_aiquny@...cinc.com,
kernel@...cinc.com, linux-arm-msm@...r.kernel.org,
devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 5/8] dt-bindings: arm: qcom,ids: Adjust the position of
QCOM_ID_QDU1010
On 31/07/2023 09:21, Tengfei Fan wrote:
>
>
> 在 7/31/2023 3:00 PM, Krzysztof Kozlowski 写道:
>> On 31/07/2023 08:13, Tengfei Fan wrote:
>>> Adjust the position of QCOM_ID_QDU1010, so that there is a coherent
>>> sequence of numbers.
>>>
>>> Change-Id: Id083e1ecc92c063c1a07a81c66dcb034020964b0
>>
>> Please run scripts/checkpatch.pl and fix reported warnings. Some
>> warnings can be ignored, but the code here looks like it needs a fix.
>> Feel free to get in touch if the warning is not clear.
>>
> sure, will do this check if this patch still need.
I understand that resending this might not be needed, but just to
clarify: you must run checkpatch on all your patches before sending
them. This is the most basic step required before sending anything.
Best regards,
Krzysztof
Powered by blists - more mailing lists