linux-kernel - Re: [PATCH] vduse: Use proper spinlock for IRQ injection

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CACycT3tVOKVvhTab7cbjFJsVk3vnWwqyaZ6pGvKmxO8jADj65Q@mail.gmail.com>
Date:   Mon, 31 Jul 2023 10:24:47 +0800
From:   Yongji Xie <xieyongji@...edance.com>
To:     Maxime Coquelin <maxime.coquelin@...hat.com>
Cc:     Jason Wang <jasowang@...hat.com>,
        "Michael S. Tsirkin" <mst@...hat.com>,
        David Marchand <david.marchand@...hat.com>,
        Cindy Lu <lulu@...hat.com>,
        linux-kernel <linux-kernel@...r.kernel.org>,
        virtualization <virtualization@...ts.linux-foundation.org>,
        Netdev <netdev@...r.kernel.org>, xuanzhuo@...ux.alibaba.com,
        Eugenio Perez Martin <eperezma@...hat.com>
Subject: Re: [PATCH] vduse: Use proper spinlock for IRQ injection

On Wed, Jul 5, 2023 at 7:45 PM Maxime Coquelin
<maxime.coquelin@...hat.com> wrote:
>
> The IRQ injection work used spin_lock_irq() to protect the
> scheduling of the softirq, but spin_lock_bh() should be
> used.
>
> With spin_lock_irq(), we noticed delay of more than 6
> seconds between the time a NAPI polling work is scheduled
> and the time it is executed.
>
> Fixes: c8a6153b6c59 ("vduse: Introduce VDUSE - vDPA Device in Userspace")
> Cc: xieyongji@...edance.com
>
> Suggested-by: Jason Wang <jasowang@...hat.com>
> Signed-off-by: Maxime Coquelin <maxime.coquelin@...hat.com>

Reviewed-by: Xie Yongji <xieyongji@...edance.com>

Thanks,
Yongji