linux-kernel - Re: [PATCH] ARM: dts: qcom: use defines for interrupts

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <21f654b5-5b9e-2486-889a-f6c884706f7f@linaro.org>
Date:   Mon, 31 Jul 2023 11:14:09 +0200
From:   Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To:     Konrad Dybcio <konrad.dybcio@...aro.org>,
        Andy Gross <agross@...nel.org>,
        Bjorn Andersson <andersson@...nel.org>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Conor Dooley <conor+dt@...nel.org>,
        linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ARM: dts: qcom: use defines for interrupts

On 31/07/2023 10:07, Konrad Dybcio wrote:
> On 30.07.2023 13:15, Krzysztof Kozlowski wrote:
>> Replace hard-coded interrupt parts (GIC, flags) with standard defines
>> for readability.  No changes in resulting DTBs.
>>
>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
>> ---
>>  arch/arm/boot/dts/qcom/qcom-apq8064.dtsi | 44 ++++++++++++------------
>>  arch/arm/boot/dts/qcom/qcom-ipq4019.dtsi |  2 +-
>>  arch/arm/boot/dts/qcom/qcom-msm8660.dtsi | 22 ++++++------
>>  arch/arm/boot/dts/qcom/qcom-msm8974.dtsi |  6 ++--
>>  arch/arm/boot/dts/qcom/qcom-sdx55.dtsi   | 18 +++++-----
>>  arch/arm/boot/dts/qcom/qcom-sdx65.dtsi   | 26 +++++++-------
>>  6 files changed, 59 insertions(+), 59 deletions(-)
>>
>> diff --git a/arch/arm/boot/dts/qcom/qcom-apq8064.dtsi b/arch/arm/boot/dts/qcom/qcom-apq8064.dtsi
>> index e0adf237fc5c..c693bfc63488 100644
>> --- a/arch/arm/boot/dts/qcom/qcom-apq8064.dtsi
>> +++ b/arch/arm/boot/dts/qcom/qcom-apq8064.dtsi
>> @@ -190,7 +190,7 @@ cpu_crit3: trip1 {
>>  
>>  	cpu-pmu {
>>  		compatible = "qcom,krait-pmu";
>> -		interrupts = <1 10 0x304>;
>> +		interrupts = <GIC_PPI 10 0x304>;
> Looks like 0x304 would be (IRQ_TYPE_LEVEL_HIGH | IRQ_LEVEL | IRQ_PER_CPU)
> 
> 
> [...]
> 
>>  	timer {
>>  		compatible = "arm,armv7-timer";
>> -		interrupts = <1 2 0xf08>,
>> +		interrupts = <GIC_PPI 2 0xf08>,
> 0xf08 -> (IRQ_LEVEL | IRQ_PER_CPU | IRQ_NOPROBE | IRQ_NOREQUEST | IRQ_TYPE_LEVEL_LOW)
> 
> there's a couple more 0x3XX and 0xfXX in there

I was too lazy to decode these, but since you did the hard part, I will
change them. :) Thanks

Best regards,
Krzysztof