linux-kernel - Re: [PATCH v5 2/2] soc: loongson2_pm: add power management support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <97ae94ff-3b0c-b89d-3436-18839739de17@loongson.cn>
Date:   Mon, 31 Jul 2023 11:12:47 +0800
From:   Yinbo Zhu <zhuyinbo@...ngson.cn>
To:     Arnd Bergmann <arnd@...db.de>, Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Conor Dooley <conor+dt@...nel.org>, linux-pm@...r.kernel.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        Ulf Hansson <ulf.hansson@...aro.org>
Cc:     Jianmin Lv <lvjianmin@...ngson.cn>, wanghongliang@...ngson.cn,
        Liu Peibao <liupeibao@...ngson.cn>,
        loongson-kernel@...ts.loongnix.cn, Liu Yun <liuyun@...ngson.cn>,
        zhuyinbo@...ngson.cn
Subject: Re: [PATCH v5 2/2] soc: loongson2_pm: add power management support



在 2023/7/28 下午6:46, Arnd Bergmann 写道:
> On Fri, Jul 28, 2023, at 09:49, Yinbo Zhu wrote:
>> The Loongson-2's power management controller was ACPI, supports ACPI
>> S2Idle (Suspend To Idle), ACPI S3 (Suspend To RAM), ACPI S4 (Suspend To
>> Disk), ACPI S5 (Soft Shutdown) and supports multiple wake-up methods
>> (USB, GMAC, PWRBTN, etc.). This driver was to add power management
>> controller support that base on dts for Loongson-2 series SoCs.
>>
>> Co-developed-by: Liu Yun <liuyun@...ngson.cn>
>> Signed-off-by: Liu Yun <liuyun@...ngson.cn>
>> Co-developed-by: Liu Peibao <liupeibao@...ngson.cn>
>> Signed-off-by: Liu Peibao <liupeibao@...ngson.cn>
>> Signed-off-by: Yinbo Zhu <zhuyinbo@...ngson.cn>
> 
> Adding Ulf Hansson to Cc


okay, I will add ulf hansson to Cc.

> 
> Ulf has recently split out the "genpd" framework and split out
> drivers/genpd from drivers/soc since I'm generally not that involved
> in the pwoer management side.

okay, I got it.

> 
> Can you have a look at whether this driver should also be part
> of drivers/genpd rather than drivers/soc, and/or converted
> to use the genpd infrastructure?


I have a look drivers/soc and drivers/genpd, there seems to be power
manager code in both paths, but drivers/genpd seems more suitable. I
will move the code to drivers/genpd

Thanks,
Yinbo