linux-kernel - Re: [PATCH 1/1] tpm: disable hwrng for fTPM on some AMD designs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230731132837.64690d7b@g14>
Date:   Mon, 31 Jul 2023 10:28:37 +0000
From:   Daniil Stas <daniil.stas@...teo.net>
To:     "Jarkko Sakkinen" <jarkko@...nel.org>
Cc:     <mario.limonciello@....com>,
        <James.Bottomley@...senpartnership.com>, <Jason@...c4.com>,
        <linux-integrity@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <regressions@...mhuis.info>, <stable@...r.kernel.org>,
        <torvalds@...ux-foundation.org>
Subject: Re: [PATCH 1/1] tpm: disable hwrng for fTPM on some AMD designs

On Mon, 31 Jul 2023 10:14:05 +0000
"Jarkko Sakkinen" <jarkko@...nel.org> wrote:

> On Fri Jul 28, 2023 at 8:18 PM UTC, Daniil Stas wrote:
> > On Fri, 28 Jul 2023 19:30:18 +0000
> > "Jarkko Sakkinen" <jarkko@...nel.org> wrote:
> >  
> > > On Thu Jul 27, 2023 at 3:38 PM UTC, Daniil Stas wrote:  
>  [...]  
> > > 
> > > This is needs a bit more elaboration in order to be comprehended.
> > > 
> > > Do you mean by "stutter" unexpected delays and when do they
> > > happen?
> > > 
> > > BR, Jarkko  
> >
> > Yes, unexpected delays. They just happen randomly.
> > You can google "AMD fTPM stuttering", there are a lot of examples.
> > Here is one: https://www.youtube.com/watch?v=TYnRL-x6DVI  
> 
> What if you make tpm_amd_is_rng_defective() to unconditonally return
> true? Does this make the problem dissappear, or not?
> 
> BR, Jarkko

I already tried compiling kernel without CONFIG_HW_RANDOM_TPM enabled,
which does the same.
Yes, it removes the issue.