linux-kernel - Re: [PATCH] hwrng: add Zhaoxin HW RNG driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <e8140373-9249-e2cb-9767-8459f90245ee@zhaoxin.com>
Date:   Mon, 31 Jul 2023 11:19:35 +0800
From:   LeoLiu-oc <leoliu-oc@...oxin.com>
To:     Corentin Labbe <clabbe.montjoie@...il.com>
CC:     <olivia@...enic.com>, <herbert@...dor.apana.org.au>,
        <jiajie.ho@...rfivetech.com>, <conor.dooley@...rochip.com>,
        <martin@...ser.cx>, <mmyangfl@...il.com>,
        <jenny.zhang@...rfivetech.com>, <linux-kernel@...r.kernel.org>,
        <linux-crypto@...r.kernel.org>, <leoliu@...oxin.com>,
        <CobeChen@...oxin.com>, <YunShen@...oxin.com>,
        <TonyWWang@...oxin.com>
Subject: Re: [PATCH] hwrng: add Zhaoxin HW RNG driver



在 2023/7/27 14:48, Corentin Labbe 写道:
> Le Wed, Jul 26, 2023 at 07:35:53PM +0800, LeoLiu-oc a écrit :
>> From: leoliu-oc <leoliu-oc@...oxin.com>
>>
>> Add support for Zhaoxin HW RNG.
>>
>> Signed-off-by: leoliu-oc <leoliu-oc@...oxin.com>
>> ---
>>   drivers/char/hw_random/Kconfig       |  13 +++
>>   drivers/char/hw_random/Makefile      |   1 +
>>   drivers/char/hw_random/via-rng.c     |  17 ++--
> 
> Hello
> 
> You are doing changes in via-rng without stating why.
> If changes are needed in via-rng, you should do this in a separate patch.
> 
> Regards

OK，Got it.Thanks for your advice,I will modify it in the next version.

Leoliu-oc