linux-kernel - Re: [PATCH] media: dt-bindings: Merge OV5695 into OV5693 binding

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZMeZIGyD+ET6gaox@valkosipuli.retiisi.eu>
Date:   Mon, 31 Jul 2023 11:21:04 +0000
From:   Sakari Ailus <sakari.ailus@....fi>
To:     Rob Herring <robh@...nel.org>
Cc:     Mauro Carvalho Chehab <mchehab@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Conor Dooley <conor+dt@...nel.org>,
        Daniel Scally <djrscally@...il.com>,
        Dafna Hirschfeld <dafna@...tmail.com>,
        Heiko Stuebner <heiko@...ech.de>,
        Tommaso Merciai <tommaso.merciai@...rulasolutions.com>,
        Helen Koike <helen.koike@...labora.com>,
        linux-media@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-rockchip@...ts.infradead.org,
        linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH] media: dt-bindings: Merge OV5695 into OV5693 binding

Hi Rob,

On Fri, Jul 07, 2023 at 03:06:04PM -0600, Rob Herring wrote:
> The OV5695 binding is almost the same as the OV5693 binding. The only
> difference is 'clock-names' is defined for OV5695. However, the lack of
> clock-names is an omission as the Linux OV5693 driver expects the same
> 'xvclk' clock name.
> 
> 'link-frequencies' is required by OV5693, but not OV5695. Just drop it
> from being required. Expressing it conditionally would be ugly. It
> shouldn't really be required either as the driver only supports 1
> frequency anyways.

The correct way to address this would appear to be to add link-frequencies
for both of these devices. I think I've seen one or two sensors of this
class (raw, CSI-2/parallel, external clock etc.) with link frequencies
documented as "fixed" --- which is probably a documentation issue more than
anything else.

Also see:
<URL:https://hverkuil.home.xs4all.nl/spec/driver-api/camera-sensor.html#handling-clocks>.

-- 
Kind regards,

Sakari Ailus