linux-kernel - Re: [PATCH V2 4/5] ubi: Reserve sufficient buffer length for the input mask

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <412c027f-a96c-6de3-f493-749566e8c3ac@huawei.com>
Date:   Mon, 31 Jul 2023 20:13:55 +0800
From:   Zhihao Cheng <chengzhihao1@...wei.com>
To:     ZhaoLong Wang <wangzhaolong1@...wei.com>, <richard@....at>,
        <miquel.raynal@...tlin.com>, <vigneshr@...com>
CC:     <linux-mtd@...ts.infradead.org>, <linux-kernel@...r.kernel.org>,
        <yi.zhang@...wei.com>
Subject: Re: [PATCH V2 4/5] ubi: Reserve sufficient buffer length for the
 input mask

在 2023/7/18 16:51, ZhaoLong Wang 写道:
> Because the mask received by the emulate_failures interface
> is a 32-bit unsigned integer, ensure that there is sufficient
> buffer length to receive and display this value.
> 
> Signed-off-by: ZhaoLong Wang <wangzhaolong1@...wei.com>
> ---
> V2:
>    - A 16-byte buffer is reserved, as implemented by other interfaces.
> 
>   drivers/mtd/ubi/debug.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/mtd/ubi/debug.c b/drivers/mtd/ubi/debug.c
> index 016a861c5029..1c3f1a2436e5 100644
> --- a/drivers/mtd/ubi/debug.c
> +++ b/drivers/mtd/ubi/debug.c
> @@ -332,7 +332,7 @@ static ssize_t dfs_file_read(struct file *file, char __user *user_buf,
>   	struct dentry *dent = file->f_path.dentry;
>   	struct ubi_device *ubi;
>   	struct ubi_debug_info *d;
> -	char buf[8];
> +	char buf[16];
>   	int val;
>   
>   	ubi = ubi_get_device(ubi_num);
> @@ -400,7 +400,7 @@ static ssize_t dfs_file_write(struct file *file, const char __user *user_buf,
>   	struct ubi_device *ubi;
>   	struct ubi_debug_info *d;
>   	size_t buf_size;
> -	char buf[8] = {0};
> +	char buf[16] = {0};
>   	int val;
>   
>   	ubi = ubi_get_device(ubi_num);
> 


Reviewed-by: Zhihao Cheng <chengzhihao1@...wei.com>