linux-kernel - Re: [PATCH 1/1] fbdev: mmp: fix value check in mmphw

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <f84bbc50-2cd1-833d-7e99-e669cfc17c74@gmx.de>
Date:   Mon, 31 Jul 2023 14:43:58 +0200
From:   Helge Deller <deller@....de>
To:     Yuanjun Gong <ruc_gongyuanjun@....com>,
        Christophe JAILLET <christophe.jaillet@...adoo.fr>,
        Lisa Du <cldu@...vell.com>, linux-fbdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/1] fbdev: mmp: fix value check in mmphw_probe()

On 7/27/23 19:03, Yuanjun Gong wrote:
> in mmphw_probe(), check the return value of clk_prepare_enable()
> and return the error code if clk_prepare_enable() returns an
> unexpected value.
>
> Fixes: d63028c38905 ("video: mmp display controller support")
> Signed-off-by: Yuanjun Gong <ruc_gongyuanjun@....com>

applied.
Thanks!
Helge

> ---
>   drivers/video/fbdev/mmp/hw/mmp_ctrl.c | 4 +++-
>   1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/video/fbdev/mmp/hw/mmp_ctrl.c b/drivers/video/fbdev/mmp/hw/mmp_ctrl.c
> index 51fbf02a0343..76b50b6c98ad 100644
> --- a/drivers/video/fbdev/mmp/hw/mmp_ctrl.c
> +++ b/drivers/video/fbdev/mmp/hw/mmp_ctrl.c
> @@ -519,7 +519,9 @@ static int mmphw_probe(struct platform_device *pdev)
>   			      "unable to get clk %s\n", mi->clk_name);
>   		goto failed;
>   	}
> -	clk_prepare_enable(ctrl->clk);
> +	ret = clk_prepare_enable(ctrl->clk);
> +	if (ret)
> +		goto failed;
>
>   	/* init global regs */
>   	ctrl_set_default(ctrl);