[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <a3f6a213-574e-7351-1d4f-a698116d6c95@linaro.org>
Date: Mon, 31 Jul 2023 07:02:23 +0300
From: Dmitry Baryshkov <dmitry.baryshkov@...aro.org>
To: Jessica Zhang <quic_jesszhan@...cinc.com>,
Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>,
Maxime Ripard <mripard@...nel.org>,
Thomas Zimmermann <tzimmermann@...e.de>,
David Airlie <airlied@...il.com>,
Daniel Vetter <daniel@...ll.ch>,
Rob Clark <robdclark@...il.com>, Sean Paul <sean@...rly.run>,
Marijn Suijten <marijn.suijten@...ainline.org>
Cc: quic_abhinavk@...cinc.com, ppaalanen@...il.com,
contact@...rsion.fr, laurent.pinchart@...asonboard.com,
sebastian.wick@...hat.com, ville.syrjala@...ux.intel.com,
dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org,
linux-arm-msm@...r.kernel.org, freedreno@...ts.freedesktop.org,
wayland-devel@...ts.freedesktop.org
Subject: Re: [PATCH RFC v5 03/10] drm: Add solid fill pixel source
On 28/07/2023 20:02, Jessica Zhang wrote:
> Add "SOLID_FILL" as a valid pixel source. If the pixel_source property is
> set to "SOLID_FILL", it will display data from the drm_plane "solid_fill"
> blob property.
>
> Signed-off-by: Jessica Zhang <quic_jesszhan@...cinc.com>
> ---
> drivers/gpu/drm/drm_blend.c | 10 +++++++++-
> include/drm/drm_plane.h | 1 +
> 2 files changed, 10 insertions(+), 1 deletion(-)
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@...aro.org>
>
> diff --git a/drivers/gpu/drm/drm_blend.c b/drivers/gpu/drm/drm_blend.c
> index c632dfcd8a9b..34b1fd3e2310 100644
> --- a/drivers/gpu/drm/drm_blend.c
> +++ b/drivers/gpu/drm/drm_blend.c
> @@ -200,6 +200,9 @@
> * "FB":
> * Framebuffer source set by the "FB_ID" property.
> *
> + * "SOLID_FILL":
> + * Solid fill color source set by the "solid_fill" property.
> + *
> * solid_fill:
> * solid_fill is set up with drm_plane_create_solid_fill_property(). It
> * contains pixel data that drivers can use to fill a plane.
> @@ -657,6 +660,9 @@ EXPORT_SYMBOL(drm_plane_create_blend_mode_property);
> * "FB":
> * Framebuffer pixel source
> *
> + * "SOLID_FILL":
> + * Solid fill color pixel source
> + *
> * Returns:
> * Zero on success, negative errno on failure.
> */
> @@ -668,8 +674,10 @@ int drm_plane_create_pixel_source_property(struct drm_plane *plane,
> static const struct drm_prop_enum_list enum_list[] = {
> { DRM_PLANE_PIXEL_SOURCE_NONE, "NONE" },
> { DRM_PLANE_PIXEL_SOURCE_FB, "FB" },
> + { DRM_PLANE_PIXEL_SOURCE_SOLID_FILL, "SOLID_FILL" },
> };
> - static const unsigned int valid_source_mask = BIT(DRM_PLANE_PIXEL_SOURCE_FB);
> + static const unsigned int valid_source_mask = BIT(DRM_PLANE_PIXEL_SOURCE_FB) |
> + BIT(DRM_PLANE_PIXEL_SOURCE_SOLID_FILL);
> int i;
>
> /* FB is supported by default */
> diff --git a/include/drm/drm_plane.h b/include/drm/drm_plane.h
> index abf1458fa099..234fee3d5a95 100644
> --- a/include/drm/drm_plane.h
> +++ b/include/drm/drm_plane.h
> @@ -43,6 +43,7 @@ enum drm_scaling_filter {
> enum drm_plane_pixel_source {
> DRM_PLANE_PIXEL_SOURCE_NONE,
> DRM_PLANE_PIXEL_SOURCE_FB,
> + DRM_PLANE_PIXEL_SOURCE_SOLID_FILL,
> DRM_PLANE_PIXEL_SOURCE_MAX
> };
>
>
--
With best wishes
Dmitry
Powered by blists - more mailing lists