linux-kernel - Re: [PATCH v4 0/7] Add initial support for SM7125 and Xiaomi SM7125 platform

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <kzdqrhzegfvon6o4xzlqrabhrx432qmqv55r5vp6v5cpy7oyip@d5bbegprhnrq>
Date:   Mon, 31 Jul 2023 14:58:08 +0200
From:   Marijn Suijten <marijn.suijten@...ainline.org>
To:     David Wronek <davidwronek@...il.com>
Cc:     Andy Gross <agross@...nel.org>,
        Bjorn Andersson <andersson@...nel.org>,
        Konrad Dybcio <konrad.dybcio@...aro.org>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Conor Dooley <conor+dt@...nel.org>,
        Michael Turquette <mturquette@...libre.com>,
        Stephen Boyd <sboyd@...nel.org>,
        Taniya Das <quic_tdas@...cinc.com>,
        linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-clk@...r.kernel.org,
        ~postmarketos/upstreaming@...ts.sr.ht, phone-devel@...r.kernel.org,
        cros-qcom-dts-watchers@...omium.org
Subject: Re: [PATCH v4 0/7] Add initial support for SM7125 and Xiaomi SM7125
 platform

On 2023-07-23 21:05:01, David Wronek wrote:
> This series introduces support for the Qualcomm SM7125 SoC and the
> Xiaomi SM7125 platform.
> 
> Signed-off-by: David Wronek <davidwronek@...il.com>
> ---
> Changes in v2:
> - Allow qcom,board-id and qcom,msm-id properties
> - Use QCOM_SCM_VMID_MSS_MSA definition
> - Change initial regulator modes from LPM to HPM
> - Move status to the bottom of nodes
> - Fix up PM6150 interrupts
> - Move clk patch to beginning of series
> - Fix up copyright
> - Take ownership of all commits with permission
> - Link to v1: https://lore.kernel.org/all/20230704163848.169853-2-davidwronek@gmail.com/
> 
> Changes in v3:
> - Disable pm6150 rtc by default
> - Fix wrong pm8150l PMIC in joyeuse dts
> - Link to v2: https://lore.kernel.org/all/20230706124339.134272-1-davidwronek@gmail.com/
> 
> Changes in v4:
> - Fix key-vol-down node name
> - Link to v3: https://lore.kernel.org/all/20230715091932.161507-1-davidwronek@gmail.com/
> 
> ---
> David Wronek (7):
>   clk: qcom: gcc-sc7180: Fix up gcc_sdcc2_apps_clk_src
>   dt-bindings: arm: qcom,ids: Add SoC ID for SM7125
>   dt-bindings: arm: qcom: Document SM7125 and xiaomi,joyeuse board
>   soc: qcom: socinfo: Add SoC ID for SM7125
>   arm64: dts: qcom: pm6150: Add resin and rtc nodes
>   arm64: dts: qcom: Add SM7125 device tree
>   arm64: dts: qcom: Add support for the Xiaomi SM7125 platform
> 
>  .../devicetree/bindings/arm/qcom.yaml         |   7 +
>  arch/arm64/boot/dts/qcom/Makefile             |   1 +
>  arch/arm64/boot/dts/qcom/pm6150.dtsi          |  16 +
>  .../boot/dts/qcom/sm7125-xiaomi-joyeuse.dts   |  16 +
>  .../boot/dts/qcom/sm7125-xiaomi-miatoll.dtsi  | 423 ++++++++++++++++++

As brought up on IRC, making it official review by reposting it here on
the lists: Since mi+atoll seems to be a community made-up name, perhaps
this file should just be named sm7125-xiomi-common.dtsi, matching
similar Xiaomi and OnePlus devices with shared DTSI?

Otherwise, just like Sony devices where an official board name _is
known_ the device DTS file should have been named
sm7125-xiaomi-miatoll-joyeuse.dts instead?

- Marijn

>  arch/arm64/boot/dts/qcom/sm7125.dtsi          |  16 +
>  drivers/clk/qcom/gcc-sc7180.c                 |   1 +
>  drivers/soc/qcom/socinfo.c                    |   1 +
>  include/dt-bindings/arm/qcom,ids.h            |   1 +
>  9 files changed, 482 insertions(+)
>  create mode 100644 arch/arm64/boot/dts/qcom/sm7125-xiaomi-joyeuse.dts
>  create mode 100644 arch/arm64/boot/dts/qcom/sm7125-xiaomi-miatoll.dtsi
>  create mode 100644 arch/arm64/boot/dts/qcom/sm7125.dtsi
> 
> -- 
> 2.41.0
>