[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-Id: <20230801144136.23565-1-lhenriques@suse.de>
Date: Tue, 1 Aug 2023 15:41:36 +0100
From: Luís Henriques <lhenriques@...e.de>
To: "Theodore Ts'o" <tytso@....edu>,
Andreas Dilger <adilger.kernel@...ger.ca>
Cc: linux-ext4@...r.kernel.org, linux-kernel@...r.kernel.org,
Luís Henriques <lhenriques@...e.de>
Subject: [PATCH] ext4: fix memory leak in ext4_fname_setup_filename() error path
If casefolding the filename fails, we'll be leaking fscrypt_buf name.
Make sure we free it in the error path.
Signed-off-by: Luís Henriques <lhenriques@...e.de>
---
fs/ext4/crypto.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/fs/ext4/crypto.c b/fs/ext4/crypto.c
index e20ac0654b3f..9e4503b051c4 100644
--- a/fs/ext4/crypto.c
+++ b/fs/ext4/crypto.c
@@ -33,6 +33,8 @@ int ext4_fname_setup_filename(struct inode *dir, const struct qstr *iname,
#if IS_ENABLED(CONFIG_UNICODE)
err = ext4_fname_setup_ci_filename(dir, iname, fname);
+ if (err)
+ fscrypt_free_filename(&name);
#endif
return err;
}
Powered by blists - more mailing lists