linux-kernel - Re: [PATCH V7 net] net: mana: Fix MANA VF unload when hardware is

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZMklUch+vfZBqfAr@kernel.org>
Date:   Tue, 1 Aug 2023 17:31:29 +0200
From:   Simon Horman <horms@...nel.org>
To:     Souradeep Chakrabarti <schakrabarti@...ux.microsoft.com>
Cc:     kys@...rosoft.com, haiyangz@...rosoft.com, wei.liu@...nel.org,
        decui@...rosoft.com, davem@...emloft.net, edumazet@...gle.com,
        kuba@...nel.org, pabeni@...hat.com, longli@...rosoft.com,
        sharmaajay@...rosoft.com, leon@...nel.org, cai.huoqing@...ux.dev,
        ssengar@...ux.microsoft.com, vkuznets@...hat.com,
        tglx@...utronix.de, linux-hyperv@...r.kernel.org,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-rdma@...r.kernel.org, schakrabarti@...rosoft.com,
        stable@...r.kernel.org
Subject: Re: [PATCH V7 net] net: mana: Fix MANA VF unload when hardware is

On Tue, Aug 01, 2023 at 05:29:13AM -0700, Souradeep Chakrabarti wrote:

...

Hi Souradeep,


> +	for (i = 0; i < apc->num_queues; i++) {
> +		txq = &apc->tx_qp[i].txq;
> +		while (skb = skb_dequeue(&txq->pending_skbs)) {

W=1 builds with both clang-16 and gcc-12 complain that
they would like an extra set of parentheses around
an assignment used as a truth value.

> +			mana_unmap_skb(skb, apc);
> +			dev_consume_skb_any(skb);
> +		}
> +		atomic_set(&txq->pending_sends, 0);
> +	}
>  	/* We're 100% sure the queues can no longer be woken up, because
>  	 * we're sure now mana_poll_tx_cq() can't be running.
>  	 */
> -- 
> 2.34.1
> 
>