linux-kernel - Re: [PATCH 1/2] dt-bindings: ARM: at91: Document Microchip SAMA5D29 Curiosity

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230801-unbalance-baguette-cd0d4e7e0107@spud>
Date:   Tue, 1 Aug 2023 16:35:15 +0100
From:   Conor Dooley <conor@...nel.org>
To:     Mihai Sain <mihai.sain@...rochip.com>
Cc:     robh+dt@...nel.org, krzysztof.kozlowski+dt@...aro.org,
        conor+dt@...nel.org, nicolas.ferre@...rochip.com,
        alexandre.belloni@...tlin.com, claudiu.beznea@...rochip.com,
        andre.przywara@....com, andrei.simion@...rochip.com,
        jerry.ray@...rochip.com, devicetree@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
        cristian.birsan@...rochip.com
Subject: Re: [PATCH 1/2] dt-bindings: ARM: at91: Document Microchip SAMA5D29
 Curiosity

Hey,

On Tue, Aug 01, 2023 at 02:11:50PM +0300, Mihai Sain wrote:
> From: Andrei Simion <andrei.simion@...rochip.com>
> 
> Document device tree binding of SAMA5D29 Curiosity, from Microchip.
> 
> Reviewed-by: Mihai Sain <mihai.sain@...rochip.com>
> Signed-off-by: Andrei Simion <andrei.simion@...rochip.com>

Your SoB is missing from here.

> ---
>  Documentation/devicetree/bindings/arm/atmel-at91.yaml | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/arm/atmel-at91.yaml b/Documentation/devicetree/bindings/arm/atmel-at91.yaml
> index dfb8fd089197..89d75fbb1de4 100644
> --- a/Documentation/devicetree/bindings/arm/atmel-at91.yaml
> +++ b/Documentation/devicetree/bindings/arm/atmel-at91.yaml
> @@ -79,6 +79,13 @@ properties:
>            - const: atmel,sama5d2
>            - const: atmel,sama5
>  
> +      - description: Microchip SAMA5D29 Curiosity
> +        items:
> +          - const: microchip,sama5d29-curiosity
> +          - const: atmel,sama5d29
> +          - const: atmel,sama5d2
> +          - const: atmel,sama5

What is the benefit of adding the two familial compatibles? Is there
software that actually uses these?

Thanks,
Conor.

> +
>        - items:
>            - const: atmel,sama5d27
>            - const: atmel,sama5d2
> -- 
> 2.41.0
> 

Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)