linux-kernel - Re: [PATCH v3 0/2] tools/nolibc: add pipe(), pipe2() and their testcase

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d8591760-8a00-4837-bc4b-21418ac7a5d6@t-8ch.de>
Date:   Tue, 1 Aug 2023 17:42:57 +0200 (GMT+02:00)
From:   Thomas Weißschuh  <thomas@...ch.de>
To:     Yuan Tan <tanyuan@...ylab.org>
Cc:     w@....eu, falcon@...ylab.org, linux-kernel@...r.kernel.org,
        linux-kselftest@...r.kernel.org
Subject: Re: [PATCH v3 0/2] tools/nolibc: add pipe(), pipe2() and their
 testcase


Aug 1, 2023 17:40:01 Yuan Tan <tanyuan@...ylab.org>:

> Hi Willy and Thomas,
>
> In v3, I have fixed all the problems you mentioned.
>
> Welcome any other suggestion.
>
> ---
> Changes in v3:
> - Fix the missing return
> - Fix __NR_pipe to __NR_pipe2
> - Fix the missing static
> - Test case works in one process
> - Link to v2:
>   https://lore.kernel.org/all/cover.1690733545.git.tanyuan@tinylab.org
>
> Changes in v2:
> - Use sys_pipe2 to implement the pipe()
> - Use memcmp() instead of strcmp()
> - Link to v1:
>   https://lore.kernel.org/all/cover.1690307717.git.tanyuan@tinylab.org
>
> ---
> Yuan Tan (2):
>   tools/nolibc: add pipe() and pipe2() support
>   selftests/nolibc: add testcase for pipe
>
> tools/include/nolibc/sys.h                   | 24 ++++++++++++++++++++
> tools/testing/selftests/nolibc/nolibc-test.c | 22 ++++++++++++++++++
> 2 files changed, 46 insertions(+)

For the full series:

Reviewed-by: Thomas Weißschuh <linux@...ssschuh.net>

Thanks!