linux-kernel - Re: [PATCH] ASoC: rt5665: add missed regulator_bulk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 01 Aug 2023 23:46:36 +0800
From:   Zhang Shurong <zhang_shurong@...mail.com>
To:     Mark Brown <broonie@...nel.org>
Cc:     oder_chiou@...ltek.com, lgirdwood@...il.com, perex@...ex.cz,
        tiwai@...e.com, alsa-devel@...a-project.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ASoC: rt5665: add missed regulator_bulk_disable

在 2023年7月23日星期日 CST 下午11:12:17，Mark Brown 写道：
> On Sun, Jul 23, 2023 at 03:07:31PM +0800, Zhang Shurong wrote:
> > +	ret = devm_add_action_or_reset(&i2c->dev, 
rt5665_i2c_disable_regulators,
> > +			rt5665);
> > +	if (ret)
> > +		return ret;
> > +
> > 
> >  	ret = regulator_bulk_enable(ARRAY_SIZE(rt5665->supplies),
> >  	
> >  				    rt5665->supplies);
> >  	
> >  	if (ret != 0) {
> 
> This will attempt to disable the regulators if the initial enable fails
> which is a bug.
You are right. I will move this to rt5663_i2c_remove() in next version.