linux-kernel - Re: [PATCH V3] ovl: fix mount fail because the upper doesn't have space

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAJfpeguygW3JY5L5d+87+V538hAWu2tL9Yksg5p-QMP3ppv13w@mail.gmail.com>
Date:   Tue, 1 Aug 2023 19:43:05 +0200
From:   Miklos Szeredi <miklos@...redi.hu>
To:     Yunlong Xing <yunlong.xing@...soc.com>
Cc:     amir73il@...il.com, linux-unionfs@...r.kernel.org,
        linux-kernel@...r.kernel.org, zhiguo.niu@...soc.com,
        hongyu.jin@...soc.com, yunlongxing23@...il.com
Subject: Re: [PATCH V3] ovl: fix mount fail because the upper doesn't have space

On Thu, 20 Jul 2023 at 11:15, Yunlong Xing <yunlong.xing@...soc.com> wrote:
>
> The current ovlfs mount flow:
>
> ovl_fill_super
>  |_ovl_get_workdir
>     |_ovl_make_workdir
>        |_ovl_check_rename_whiteout
>
> In ovl_check_rename_whiteout(), a new file is attempted to create.But if
> the upper doesn't have space to do this, it will return error -ENOSPC,
> causing the mount fail. It means that if the upper is full, the overlayfs
> cannot be mounted. It is not reasonable, so this patch will omit this error
> and continue mount flow.

Wouldn't mounting without upper (two or more lower layers) work in this case?

Thanks,
Miklos