[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <a0d5ec0a-e5d9-5938-fa6b-1d60b2aac019@linux.intel.com>
Date: Tue, 1 Aug 2023 13:48:45 -0400
From: "Liang, Kan" <kan.liang@...ux.intel.com>
To: Ian Rogers <irogers@...gle.com>,
Peter Zijlstra <peterz@...radead.org>,
Ingo Molnar <mingo@...hat.com>,
Arnaldo Carvalho de Melo <acme@...nel.org>,
Mark Rutland <mark.rutland@....com>,
Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
Jiri Olsa <jolsa@...nel.org>,
Namhyung Kim <namhyung@...nel.org>,
Adrian Hunter <adrian.hunter@...el.com>,
Ravi Bangoria <ravi.bangoria@....com>,
linux-perf-users@...r.kernel.org, linux-kernel@...r.kernel.org,
Andi Kleen <ak@...ux.intel.com>,
Weilin Wang <weilin.wang@...el.com>
Subject: Re: [PATCH v1 0/4] Intel metric fixes and event updates
On 2023-08-01 1:36 a.m., Ian Rogers wrote:
> The metric tma_info_pipeline_retire contains uops_retired.slots with
> perf metric events. Patch 1 fixes this event sorting so that
> uops_retired.slots isn't made a group leader as that needs to be
> topdown.slots.
>
> Patch 2 and 3 update the meteorlake and sapphirerapids events.
>
> Patch 4 addresses an issue with event grouping discussed in:
> https://lore.kernel.org/lkml/20230719001836.198363-3-irogers@google.com/
> by adding and altering metric constraints. The constraints avoid
> groups for metrics where the kernel PMU fails to not open the group
> (the trigger for the weak group being removed).
>
> Ian Rogers (4):
> perf parse-events x86: Avoid sorting uops_retired.slots
> perf vendor events intel: Update meteorlake to 1.04
> perf vendor events intel: Update sapphirerapids to 1.15
> perf vendor events intel: Update Icelake+ metric constraints
>
Thanks Ian.
Reviewed-by: Kan Liang <kan.liang@...ux.intel.com>
Thanks,
Kan
> tools/perf/arch/x86/util/evlist.c | 7 +-
> tools/perf/arch/x86/util/evsel.c | 7 +-
> .../arch/x86/alderlake/adl-metrics.json | 11 +-
> .../arch/x86/alderlaken/adln-metrics.json | 2 +
> .../arch/x86/icelake/icl-metrics.json | 10 +-
> .../arch/x86/icelakex/icx-metrics.json | 10 +-
> tools/perf/pmu-events/arch/x86/mapfile.csv | 4 +-
> .../pmu-events/arch/x86/meteorlake/cache.json | 165 ++++++++++++++++++
> .../arch/x86/meteorlake/floating-point.json | 8 +
> .../arch/x86/meteorlake/frontend.json | 56 ++++++
> .../arch/x86/meteorlake/memory.json | 80 +++++++++
> .../pmu-events/arch/x86/meteorlake/other.json | 16 ++
> .../arch/x86/meteorlake/pipeline.json | 159 +++++++++++++++++
> .../arch/x86/rocketlake/rkl-metrics.json | 10 +-
> .../arch/x86/sapphirerapids/other.json | 18 ++
> .../arch/x86/sapphirerapids/spr-metrics.json | 9 +-
> .../arch/x86/tigerlake/tgl-metrics.json | 10 +-
> 17 files changed, 549 insertions(+), 33 deletions(-)
>
Powered by blists - more mailing lists