linux-kernel - Re: [PATCH] iio: dac: ad3552r: Correct device IDs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20230801190107.2ebc3e61@jic23-huawei>
Date:   Tue, 1 Aug 2023 19:01:07 +0100
From:   Jonathan Cameron <jic23@...nel.org>
To:     Marcelo Schmitt <marcelo.schmitt1@...il.com>
Cc:     nuno.sa@...log.com, lars@...afoo.de, Michael.Hennerich@...log.com,
        lgirdwood@...il.com, broonie@...nel.org, linux-iio@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] iio: dac: ad3552r: Correct device IDs

On Mon, 31 Jul 2023 08:59:35 -0300
Marcelo Schmitt <marcelo.schmitt1@...il.com> wrote:

> Device IDs for AD3542R and AD3552R were swapped.
> Change device ID values so they are correct for each DAC chip.
> 
Hi Marcelo,

Agreed with the patch and that it matches the datasheets.. However
needs more info in the description so that people know how urgent the fix is.

Missing.
- Fixes tag so we know what trees need the fix (as they include the ID in
  the fixes tag.
- Description of the user visible effects of this bug.

With those added I'll be happy to queue this up. Note I've just sent
a pull request for fixes, so not in a hurry for this - otherwise
I 'might' have figured out the details and added them whilst applying.

Thanks

Jonathan
> Signed-off-by: Marcelo Schmitt <marcelo.schmitt1@...il.com>
> ---
>  drivers/iio/dac/ad3552r.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/iio/dac/ad3552r.c b/drivers/iio/dac/ad3552r.c
> index d5ea1a1be122..a492e8f2fc0f 100644
> --- a/drivers/iio/dac/ad3552r.c
> +++ b/drivers/iio/dac/ad3552r.c
> @@ -140,8 +140,8 @@ enum ad3552r_ch_vref_select {
>  };
>  
>  enum ad3542r_id {
> -	AD3542R_ID = 0x4008,
> -	AD3552R_ID = 0x4009,
> +	AD3542R_ID = 0x4009,
> +	AD3552R_ID = 0x4008,
>  };
>  
>  enum ad3552r_ch_output_range {