linux-kernel - Re: [PATCH] dma: at_hdmac: "(foo*)" should be "(foo *)"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 2 Aug 2023 00:00:03 +0530
From:   Vinod Koul <vkoul@...nel.org>
To:     hanyu001@...suo.com
Cc:     dmaengine@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] dma: at_hdmac: "(foo*)" should be "(foo *)"

On 19-07-23, 16:48, hanyu001@...suo.com wrote:
> This patch fixes the checkpatch.pl error:
> 
> ./drivers/dma/at_hdmac.c:1119: ERROR: "(foo*)" should be "(foo *)"
> 
> Signed-off-by: Yu Han <hanyu001@...suo.com>

Thanks for the patch, the From for this patch should match the
signed-off name, pls fix and resend

> ---
>  drivers/dma/at_hdmac.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/dma/at_hdmac.c b/drivers/dma/at_hdmac.c
> index ee3a219..af747a7 100644
> --- a/drivers/dma/at_hdmac.c
> +++ b/drivers/dma/at_hdmac.c
> @@ -1116,7 +1116,7 @@ static int atdma_create_memset_lli(struct dma_chan
> *chan,
>      /* Only the first byte of value is to be used according to dmaengine */
>      fill_pattern = (char)value;
> 
> -    *(u32*)vaddr = (fill_pattern << 24) |
> +    *(u32 *)vaddr = (fill_pattern << 24) |
>                 (fill_pattern << 16) |
>                 (fill_pattern << 8) |
>                 fill_pattern;

-- 
~Vinod