linux-kernel - Re: [PATCH] dmaengine: idxd: No need to clear memory after a dma_alloc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ZMlPazK9/kXjRftJ@matsya>
Date:   Wed, 2 Aug 2023 00:01:07 +0530
From:   Vinod Koul <vkoul@...nel.org>
To:     sunran001@...suo.com
Cc:     dmaengine@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] dmaengine: idxd: No need to clear memory after a
 dma_alloc_coherent() call

On 21-07-23, 07:35, sunran001@...suo.com wrote:
> dma_alloc_coherent() already clear the allocated memory, there is no need
> to explicitly call memset().

Please fix the sender name and resend. it should match s-o-b name

> 
> Signed-off-by: Ran Sun <sunran001@...suo.com>
> ---
>  drivers/dma/idxd/device.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/dma/idxd/device.c b/drivers/dma/idxd/device.c
> index 7c74bc60f582..72330876d40a 100644
> --- a/drivers/dma/idxd/device.c
> +++ b/drivers/dma/idxd/device.c
> @@ -792,7 +792,6 @@ static int idxd_device_evl_setup(struct idxd_device
> *idxd)
>  	evl->log_size = size;
>  	evl->bmap = bmap;
> 
> -	memset(&evlcfg, 0, sizeof(evlcfg));
>  	evlcfg.bits[0] = dma_addr & GENMASK(63, 12);
>  	evlcfg.size = evl->size;

-- 
~Vinod