linux-kernel - RE: [EXT] Re: [PATCH v3 net 1/2] net: stmmac: add new mode parameter for fix_mac

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <AS8PR04MB9176FC45B9663B5BF964F58A890AA@AS8PR04MB9176.eurprd04.prod.outlook.com>
Date:   Tue, 1 Aug 2023 18:43:52 +0000
From:   Shenwei Wang <shenwei.wang@....com>
To:     Marc Kleine-Budde <mkl@...gutronix.de>
CC:     Russell King <linux@...linux.org.uk>,
        "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>,
        Maxime Coquelin <mcoquelin.stm32@...il.com>,
        Shawn Guo <shawnguo@...nel.org>,
        Sascha Hauer <s.hauer@...gutronix.de>,
        Neil Armstrong <neil.armstrong@...aro.org>,
        Kevin Hilman <khilman@...libre.com>,
        Vinod Koul <vkoul@...nel.org>, Chen-Yu Tsai <wens@...e.org>,
        Jernej Skrabec <jernej.skrabec@...il.com>,
        Samuel Holland <samuel@...lland.org>,
        Jose Abreu <joabreu@...opsys.com>,
        "imx@...ts.linux.dev" <imx@...ts.linux.dev>,
        Simon Horman <simon.horman@...igine.com>,
        Alexandre Torgue <alexandre.torgue@...s.st.com>,
        Giuseppe Cavallaro <peppe.cavallaro@...com>,
        Nobuhiro Iwamatsu <nobuhiro1.iwamatsu@...hiba.co.jp>,
        Fabio Estevam <festevam@...il.com>,
        "linux-stm32@...md-mailman.stormreply.com" 
        <linux-stm32@...md-mailman.stormreply.com>,
        Jerome Brunet <jbrunet@...libre.com>,
        Bartosz Golaszewski <bartosz.golaszewski@...aro.org>,
        Wong Vee Khee <veekhee@...le.com>,
        dl-linux-imx <linux-imx@....com>,
        Andrew Halaney <ahalaney@...hat.com>,
        Bhupesh Sharma <bhupesh.sharma@...aro.org>,
        Martin Blumenstingl <martin.blumenstingl@...glemail.com>,
        Revanth Kumar Uppala <ruppala@...dia.com>,
        Jochen Henneberg <jh@...neberg-systemdesign.com>,
        "linux-amlogic@...ts.infradead.org" 
        <linux-amlogic@...ts.infradead.org>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Pengutronix Kernel Team <kernel@...gutronix.de>
Subject: RE: [EXT] Re: [PATCH v3 net 1/2] net: stmmac: add new mode parameter
 for fix_mac_speed



> -----Original Message-----
> From: Marc Kleine-Budde <mkl@...gutronix.de>
> Sent: Tuesday, August 1, 2023 1:37 AM
> To: Shenwei Wang <shenwei.wang@....com>
> Cc: Russell King <linux@...linux.org.uk>; David S. Miller
> <davem@...emloft.net>; Eric Dumazet <edumazet@...gle.com>; Jakub
> Kicinski <kuba@...nel.org>; Paolo Abeni <pabeni@...hat.com>; Maxime
> Coquelin <mcoquelin.stm32@...il.com>; Shawn Guo <shawnguo@...nel.org>;
> Sascha Hauer <s.hauer@...gutronix.de>; Neil Armstrong
> <neil.armstrong@...aro.org>; Kevin Hilman <khilman@...libre.com>; Vinod
> Koul <vkoul@...nel.org>; Chen-Yu Tsai <wens@...e.org>; Jernej Skrabec
> <jernej.skrabec@...il.com>; Samuel Holland <samuel@...lland.org>; Jose
> Abreu <joabreu@...opsys.com>; imx@...ts.linux.dev; Simon Horman
> <simon.horman@...igine.com>; Alexandre Torgue
> <alexandre.torgue@...s.st.com>; Giuseppe Cavallaro
> <peppe.cavallaro@...com>; Nobuhiro Iwamatsu
> <nobuhiro1.iwamatsu@...hiba.co.jp>; Fabio Estevam <festevam@...il.com>;
> linux-stm32@...md-mailman.stormreply.com; Jerome Brunet
> <jbrunet@...libre.com>; Bartosz Golaszewski
> <bartosz.golaszewski@...aro.org>; Wong Vee Khee <veekhee@...le.com>; dl-
> linux-imx <linux-imx@....com>; Andrew Halaney <ahalaney@...hat.com>;
> Bhupesh Sharma <bhupesh.sharma@...aro.org>; Martin Blumenstingl
> <martin.blumenstingl@...glemail.com>; Revanth Kumar Uppala
> <ruppala@...dia.com>; Jochen Henneberg <jh@...neberg-systemdesign.com>;
> linux-amlogic@...ts.infradead.org; linux-arm-kernel@...ts.infradead.org;
> netdev@...r.kernel.org; linux-kernel@...r.kernel.org; Pengutronix Kernel
> Team <kernel@...gutronix.de>
> Subject: [EXT] Re: [PATCH v3 net 1/2] net: stmmac: add new mode parameter
> for fix_mac_speed
> 
> On 31.07.2023 11:19:28, Shenwei Wang wrote:
> > A mode parameter has been added to the callback function of
> > fix_mac_speed to indicate the physical layer type.
> >
> > The mode can be one the following:
> > 	MLO_AN_PHY	- Conventional PHY
> > 	MLO_AN_FIXED	- Fixed-link mode
> > 	MLO_AN_INBAND	- In-band protocol
> >
> > Also use short version of 'uint' to replace the 'unsigned int' in the
> > function definitions.
> 
> There are not many users of 'uint' in the kernel and it's not used in the stmmac
> driver so far. From my point of view I would not introduce it and stick to the
> standard 'unsigned int'.
> 

Using 'uint' makes the code look cleaner because adding one extra parameter may cause some function 
declarations to span multiple lines.  This change keeps function declarations compact on a single line.

Thanks,
Shenwei

> Just my 2 cent,
> Marc
> 
> --
> Pengutronix e.K.                 | Marc Kleine-Budde          |
> Embedded Linux                   | https://www.pengutronix.de |
> Vertretung Nürnberg              | Phone: +49-5121-206917-129 |
> Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-9   |